Issue metadata
Sign in to add a comment
|
Regression: Settings icon is missing in header of window when entering overview mode for the first time |
||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3626.5/11316.5.0 dev Channel Daisy,Kip,Reks OS: Chrome OS What steps will reproduce the problem? (1)Sign-in to user>> Open Settings as a window and click on overview mode button and observe Settings icon is missing in header Actual: Settings icon is missing in header Expected: Settings icon should be seen in header This is a Regression issue as same is working fine in M68 NOTE: Issue is also seen in M69, M70, M71 and M73 Attaching screenshots for reference...
,
Dec 7
Bisected to https://chromium-review.googlesource.com/c/chromium/src/+/1346831, which has been reverted and on M72 as well, so this should be fixed. +pbos, FYI
,
Dec 7
Doesn't seem related to my change? "Issue is also seen in M69, M70, M71 and M73" and my change is in M72.
,
Dec 7
pbos - I just rebased and noticed neither settings icon or another v1 app (example opening chrome web store as a window) had the icon. I reverted https://chromium-review.googlesource.com/c/chromium/src/+/1366359 and the icons show up, although the settings one did not show up on the first try, so maybe thats the bug QA was seeing (im not sure if they tried opening overview once or twice). But none of the icons for v1 apps showing up is a bit worse.
,
Dec 7
Thanks, I can take this bug as a(nother) reason to reland that change. It should not hit M72 anymore as to my knowledge that revert has not been landed in M73.
,
Dec 7
Actually, do you want me to branch this off to a new bug? The original bug report speaks about the settings icon.
,
Dec 7
Yes, that sounds good to me, ill update the title. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by afakhry@chromium.org
, Dec 6Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)