Issue metadata
Sign in to add a comment
|
Regression : Unnecessary edit options are seen even after deleting the image in Files App Gallery |
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3626.5/11316.5.0 dev Channel Daisy,Kip,Reks OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Press 'Ctrl+F5(Overview Mode Button)' for screenshot (2)Now right click for context menu and select 'Gallery' -> In Gallery click on 'Edit' option -> edit options will be seen (3)Now click on 'Delete' option and delete the image -> 'No images in this directory' is seen but observe still able to view edit options and able to click but nothing happens (Please refer Video and Screenshot) Expected: Unnecessary edit options should not be seen after deleting the image Actual: Instead Unnecessary edit options is seen This is Regression Issue as same is working fine on M-68 Note : Issue is also seen on M-69,M-70 and M-71
,
Dec 21
Started working on this here: https://chromium-review.googlesource.com/c/chromium/src/+/1388812
,
Jan 9
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07d0aa4c7e0b5622ed434a29ec1f863b9fb6d4c4 commit 07d0aa4c7e0b5622ed434a29ec1f863b9fb6d4c4 Author: Alexander Nohe <nohe@chromium.org> Date: Wed Jan 09 17:10:34 2019 Added a check for an selected image when toggling the editor This provides a non-null check for the assert call. When the assert call was being invoked with a null value, the edit mode was not being toggled. Adding this in should allow deleting a single image to toggle the edit mode to off. Bug: 912489 Change-Id: I88cfa830d9780a5f1da94710939d4243f231aa2b Reviewed-on: https://chromium-review.googlesource.com/c/1388812 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#621191} [modify] https://crrev.com/07d0aa4c7e0b5622ed434a29ec1f863b9fb6d4c4/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/07d0aa4c7e0b5622ed434a29ec1f863b9fb6d4c4/ui/file_manager/gallery/js/slide_mode.js [modify] https://crrev.com/07d0aa4c7e0b5622ed434a29ec1f863b9fb6d4c4/ui/file_manager/integration_tests/gallery/photo_editor.js
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc82a9b25bfe303434842973712bfb2773b3c707 commit fc82a9b25bfe303434842973712bfb2773b3c707 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Jan 09 18:50:38 2019 Revert "Added a check for an selected image when toggling the editor" This reverts commit 07d0aa4c7e0b5622ed434a29ec1f863b9fb6d4c4. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 621191 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDdkMGFhNGM3ZTBiNTYyMmVkNDM0YTI5ZWMxZjg2M2I5ZmI2ZDRjNAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/18392 Sample Failed Step: non_single_process_mash_browser_tests Sample Flaky Test: GalleryBrowserTest.DeleteImageWhileEditingOnDrive Original change's description: > Added a check for an selected image when toggling the editor > > This provides a non-null check for the assert call. When the assert > call was being invoked with a null value, the edit mode was not being > toggled. Adding this in should allow deleting a single image to toggle > the edit mode to off. > > Bug: 912489 > Change-Id: I88cfa830d9780a5f1da94710939d4243f231aa2b > Reviewed-on: https://chromium-review.googlesource.com/c/1388812 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Alexander Nohe <nohe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621191} Change-Id: I232da9107f44addfa135131b0010cc2f68edf4f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912489 , 920299 Reviewed-on: https://chromium-review.googlesource.com/c/1403352 Cr-Commit-Position: refs/heads/master@{#621243} [modify] https://crrev.com/fc82a9b25bfe303434842973712bfb2773b3c707/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/fc82a9b25bfe303434842973712bfb2773b3c707/ui/file_manager/gallery/js/slide_mode.js [modify] https://crrev.com/fc82a9b25bfe303434842973712bfb2773b3c707/ui/file_manager/integration_tests/gallery/photo_editor.js
,
Jan 9
Was reverted. Looking into strengthening the tests.
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fc2f9b5f9298f5c509b80f6969d2951c96aeb5d commit 1fc2f9b5f9298f5c509b80f6969d2951c96aeb5d Author: Alexander Nohe <nohe@chromium.org> Date: Thu Jan 10 07:29:05 2019 Added a check for an selected image when toggling the editor This provides a non-null check for the assert call. When the assert call was being invoked with a null value, the edit mode was not being toggled. Adding this in should allow deleting a single image to toggle the edit mode to off. Bug: 912489 Change-Id: Ia4f6f4633f0856a031d1a22b15425daf68d96d12 Reviewed-on: https://chromium-review.googlesource.com/c/1404061 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#621493} [modify] https://crrev.com/1fc2f9b5f9298f5c509b80f6969d2951c96aeb5d/chrome/browser/chromeos/file_manager/gallery_browsertest.cc [modify] https://crrev.com/1fc2f9b5f9298f5c509b80f6969d2951c96aeb5d/ui/file_manager/gallery/js/slide_mode.js [modify] https://crrev.com/1fc2f9b5f9298f5c509b80f6969d2951c96aeb5d/ui/file_manager/integration_tests/gallery/photo_editor.js
,
Jan 10
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Dec 615.6 MB
15.6 MB Download