Regression : No space is seen between 'Pause' & 'Cancel' buttons on chrome://downloads page. |
|||||||||||
Issue descriptionChrome Version : 73.0.3632.0 (Official Build) 914f5b8f721ff5a734bb22a96363191c20c8c3f2-refs/branch-heads/3632@{#1} 32/64 bit OS : Mac(10.13.6, 10.13.1, 10.14.2), Windows(7,8,10), Linux(14.04 LTS) Test URL : https://speed.hetzner.de/ What steps will reproduce the problem? 1. Launch chrome, navigate to above test URL and download "100MB.bin" file. 2. Click on 'Show All' button and observe the 'Pause' & 'Cancel' buttons on chrome://downloads page. Actual Result : No space is seen between 'Pause' & 'Cancel' buttons on chrome://downloads page. Expected Result : 'Pause' & 'Cancel' buttons should be separated adequately on chrome://downloads page. This is a regression issue broken in M-73 and below is the bisect information: Good Build : 73.0.3630.0 (Revision : 613369) Bad Build : 73.0.3631.0 (Revision : 613836) Change-Log URL: https://chromium.googlesource.com/chromium/src/+log/596a0a13619c0de2fb45022c4289892e4260573a..9cbb74720b74e9400f2780efda364231ec9c4d35 Suspecting: https://chromium.googlesource.com/chromium/src/+/9cbb74720b74e9400f2780efda364231ec9c4d35 @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank you..!
,
Dec 13
Update: Rechecked the above issue on Mac (10.13.6, 10.13.1, 10.14.2), Windows (7, 8, 8.1, 10) and Linux (14.04 LTS) OS using latest Canary version #73.0.3639.0 and the issue is FIXED. Hence, adding TE verified labels. Please refer the attached screen-cast. Thank You..!!
,
Dec 13
Requesting a merge since this is a very small safe change that is only modifying the downloads button styling, and it would be good to fix this polish issue for M-72.
,
Dec 13
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 14
,
Dec 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fe728490f965c4c09c58e85a0447c00c80332d3 commit 2fe728490f965c4c09c58e85a0447c00c80332d3 Author: rbpotter <rbpotter@chromium.org> Date: Sat Dec 15 02:54:37 2018 MD Downloads: Specify spacing between buttons (M72) Spacing between buttons on the downloads page was not specified in the styling, and was instead the result of whitespace that is removed when using the legacyOptimizations: true flag in Polymer 2. Specify 8px margin between buttons to match spacing used in other Web UI paper-buttons. Bug: 912488 Change-Id: Icca140d02fe85fbb8b847b67f6925da87e13b26f Reviewed-on: https://chromium-review.googlesource.com/c/1373137 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#616015}(cherry picked from commit cd8f284c94a8b4dc6eca584d34beeac123619371) TBR=dpapad@chromium.org Change-Id: I3761a1dc1413dfbf9c4ecd628f97b07b61faf448 Reviewed-on: https://chromium-review.googlesource.com/c/1379308 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#383} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/2fe728490f965c4c09c58e85a0447c00c80332d3/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/2fe728490f965c4c09c58e85a0447c00c80332d3/chrome/browser/resources/md_downloads/item.js
,
Dec 17
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f98a2e31bd3895e68de020d105a318641b2b208 commit 0f98a2e31bd3895e68de020d105a318641b2b208 Author: rbpotter <rbpotter@chromium.org> Date: Tue Dec 18 03:29:48 2018 Downloads WebUI: Fix now outdated comment This comment is now incorrect due to: https://chromium-review.googlesource.com/c/chromium/src/+/1373137 Bug: 912488 Change-Id: Icfdbbc794e6939e776625968206379f59dbcc8df Reviewed-on: https://chromium-review.googlesource.com/c/1381371 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#617363} [modify] https://crrev.com/0f98a2e31bd3895e68de020d105a318641b2b208/chrome/browser/resources/md_downloads/item.js
,
Dec 18
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.2) using latest Canary build : 73.0.3644.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!!
,
Dec 19
Update : Retested above issue on Mac(10.13.1 , 10.13.6 , 10.14.2) OS using Beta #72.0.3626.28 and issue is fixed. Now, proper space is seen between 'Pause' & 'Cancel' buttons in chrome://downloads page. Kindly review the attached screen-cast. Thank you!
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fe728490f965c4c09c58e85a0447c00c80332d3 Commit: 2fe728490f965c4c09c58e85a0447c00c80332d3 Author: rbpotter@chromium.org Commiter: rbpotter@chromium.org Date: 2018-12-15 02:54:37 +0000 UTC MD Downloads: Specify spacing between buttons (M72) Spacing between buttons on the downloads page was not specified in the styling, and was instead the result of whitespace that is removed when using the legacyOptimizations: true flag in Polymer 2. Specify 8px margin between buttons to match spacing used in other Web UI paper-buttons. Bug: 912488 Change-Id: Icca140d02fe85fbb8b847b67f6925da87e13b26f Reviewed-on: https://chromium-review.googlesource.com/c/1373137 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#616015}(cherry picked from commit cd8f284c94a8b4dc6eca584d34beeac123619371) TBR=dpapad@chromium.org Change-Id: I3761a1dc1413dfbf9c4ecd628f97b07b61faf448 Reviewed-on: https://chromium-review.googlesource.com/c/1379308 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#383} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd5dea2824a04d146910b94fe465dbe8abf033aa commit fd5dea2824a04d146910b94fe465dbe8abf033aa Author: Dan Beam <dbeam@chromium.org> Date: Thu Jan 10 18:34:06 2019 Downloads: fix button spacing for dangerous downloads Screenshots: https://imgur.com/a/sDh0h81 R=rbpotter@chromium.org BUG= 912488 Change-Id: I65466a3d0905f6ba392b92f790b24e2dd068de58 Reviewed-on: https://chromium-review.googlesource.com/c/1403927 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#621657} [modify] https://crrev.com/fd5dea2824a04d146910b94fe465dbe8abf033aa/chrome/browser/resources/md_downloads/item.html
,
Jan 11
Update : --------- Verified above issue in latest Canary build #73.0.3668.0 on Mac(10.13.1, 10.13.6, 10.14.3), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Kindly review an attached screen-cast for reference. Thank you..! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 12