New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 912452 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Regression: Unwanted focus highlight of close icon is seen when we cancel the warning message in Downloads of Guest user

Project Member Reported by rkalavakuntla@chromium.org, Dec 6

Issue description

Chrome Version:72.0.3626.5/11316.5.0 dev Channel Daisy,Kip,Reks
OS:chrome OS

What steps will reproduce the problem?
(1)(1)Browser as Guest >> Open files app >> Click on cancel icon of Warning message about Temporary files and Observe unwanted focus(Please refer video)

Actual: Unwanted focus highlight is seen when we cancel the warning message
Expected: No such unwanted focus highlight should be seen when we cancel the warning message

This is a Regression issue as same works fine in 71.0.3578.49/11151.29.0
 
ACtual focus.jpg
2.8 MB View Download
Actual.mp4
6.4 MB View Download
Expected.mp4
5.3 MB View Download
Labels: CrOSFilesCategory-UI
Owner: slangley@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Type-Bug-Regression Type-Bug
We've noticed this in 69 as well, we think it's likely always been there.

Removing regression.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/308c08f9798e82e001bd7abea65d8486dd3ad3da

commit 308c08f9798e82e001bd7abea65d8486dd3ad3da
Author: Stuart Langley <slangley@google.com>
Date: Thu Dec 20 05:33:46 2018

Fix banner-close 'X' being displayed after closing the banner.

This element was still being show after the banner is closed because of
the css attribute "position: absolute". Rather than trying to play
around with the css to try and fix it, just hide the element.


Bug:  912452 
Change-Id: I3f1ed396127084357b37a619ee9507c850b3c1b4
Reviewed-on: https://chromium-review.googlesource.com/c/1385697
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618120}
[modify] https://crrev.com/308c08f9798e82e001bd7abea65d8486dd3ad3da/ui/file_manager/file_manager/foreground/js/ui/banners.js

Status: Fixed (was: Assigned)
Cc: fukino@chromium.org sa...@chromium.org jbanavatu@chromium.org kavvaru@chromium.org brajkumar@chromium.org
 Issue 749497  has been merged into this issue.

Sign in to add a comment