New issue
Advanced search Search tips

Issue 912446 link

Starred by 1 user
Status: Assigned
Owner:
ellyjo...@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:Vertical Dragging Bar is seen before apps icon in bookmark bar.

Project Member Reported by shru...@virtusa.com, Dec 6 
Chrome Version:73.0.3631.0 (Official Build) Revision	0507e4d4c7c2d9effb5596bcf24fcc70183775c4-refs/branch-heads/3631@{#1}(64-bit)
OS : Mac(10.13.6, 10.13.1, 10.14.2)

Steps to reproduce:
1. Launch chrome and Open NTP.
2. Drag Thumbnail to bookmark bar and observe.

Actual Result   : Vertical Dragging Bar is seen before apps icon in bookmark bar.
Expected Result : Vertical Dragging Bar should not be seen before apps icon in bookmark bar instead it should be seen at drop location.

This is a regression issue broken in M-70 and below is the bisect information:
Good Build : 70.0.3503.0 (Revision : 578160)
Bad Build : 70.0.3504.0 (Revision : 578510)

You are probably looking for a change made after 578333 (known good), but no later than 578334 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/bcb7db78edc13f57577f0a9562c98918bdcc10ae..67d21d10815fe6d87d1785a65a50fbc386e6605b

Suspecting: https://chromium.googlesource.com/chromium/src/+/67d21d10815fe6d87d1785a65a50fbc386e6605b

@ellyjones:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.	

Kindly refer the attached screencast.

Thank You!
Actual_bookmark.mov
7.5 MB View Download
Expected_Bookmark.mov
3.7 MB View Download

Comment 1 by sangseok...@navercorp.com, Dec 6 

I can resolve this issue.
Can I take a look this issue?

Comment 3 by shru...@virtusa.com, Dec 6

Labels: Target-73

Comment 4 by ellyjo...@chromium.org, Dec 6

Labels: -Pri-1 -Target-71 -Target-72 Pri-3
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cededb4b546c5082ef1a207b67d9744481c4aa8d

commit cededb4b546c5082ef1a207b67d9744481c4aa8d
Author: sangseok.jang <sangseok.jang@navercorp.com>
Date: Fri Dec 07 15:33:10 2018

Fix layout BookmarkbarView's Indicator when BookmarkButton count is zero.

 The value of the indicator's |x| should change according to the apps_page_shortcut_ and managed_bookmarks_button_'s visble()

Bug: 912446
Change-Id: I71b9f0abef43c7a2adaed5e2e54f830b1979b14a
Reviewed-on: https://chromium-review.googlesource.com/c/1364975
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614703}
[modify] https://crrev.com/cededb4b546c5082ef1a207b67d9744481c4aa8d/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Comment 6 by shru...@virtusa.com, Dec 10

Labels: TE-Verified-M73 TE-Verified-73.0.3636.0
Update : 
Retested above issue on  Mac(10.13.1 , 10.13.6 , 10.14.2)  OS using latest Canary #73.0.3636.0 and issue is fixed.
Vertical Dragging Bar is not seen before apps icon in bookmark bar and is seen now at drop location.
Kindly review the attached screen-cast.
Thank you!
CANARY#73.0.3636.0.mov
5.8 MB View Download

Comment 7 by robliao@chromium.org, Dec 13

Labels: Hotlist-DesktopUIConsider

Comment 8 by robliao@chromium.org, Dec 13

Labels: Group-Toolbar

Comment 9 by robliao@chromium.org, Dec 18

Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged
►

Sign in to add a comment