Allow separate finch config for android servicification/network service |
||||||
Issue descriptionAndroid servicification and network service will run 2 separate finch config files, as we don't want to mess up with the UMA for each other
,
Dec 11
requesting to merge to M72 or the beta finch trial will crash.
,
Dec 11
,
Dec 12
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18d17a9c60cfb942d35bfa2f80d1cb999ad4419d commit 18d17a9c60cfb942d35bfa2f80d1cb999ad4419d Author: Min Qin <qinmin@chromium.org> Date: Wed Dec 12 01:00:19 2018 Passing a list of features to check whether service manager should be started To make ServiceManager and network service separate finch experiments, we need to allow individual feature to separately check whether both of them are enabled. This CL allows client to pass a list of features to check before starting the service manager mode. BUG=912444 Change-Id: If1770189c669f8cb68fed1a6993369410e1efbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1363839 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615322}(cherry picked from commit af4fb8016d89f7e877ac91fa1b603d8d75f8ad42) Reviewed-on: https://chromium-review.googlesource.com/c/1372567 Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#270} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/18d17a9c60cfb942d35bfa2f80d1cb999ad4419d/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/18d17a9c60cfb942d35bfa2f80d1cb999ad4419d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java [modify] https://crrev.com/18d17a9c60cfb942d35bfa2f80d1cb999ad4419d/chrome/android/java/src/org/chromium/chrome/browser/init/ServiceManagerStartupUtils.java [modify] https://crrev.com/18d17a9c60cfb942d35bfa2f80d1cb999ad4419d/chrome/browser/android/chrome_feature_list.cc
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18d17a9c60cfb942d35bfa2f80d1cb999ad4419d Commit: 18d17a9c60cfb942d35bfa2f80d1cb999ad4419d Author: qinmin@chromium.org Commiter: qinmin@chromium.org Date: 2018-12-12 01:00:19 +0000 UTC Passing a list of features to check whether service manager should be started To make ServiceManager and network service separate finch experiments, we need to allow individual feature to separately check whether both of them are enabled. This CL allows client to pass a list of features to check before starting the service manager mode. BUG=912444 Change-Id: If1770189c669f8cb68fed1a6993369410e1efbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1363839 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615322}(cherry picked from commit af4fb8016d89f7e877ac91fa1b603d8d75f8ad42) Reviewed-on: https://chromium-review.googlesource.com/c/1372567 Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#270} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 10