Findit identified the culprit r614212 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZGNmYTk5Mzg2ZDBiMGY5MTEwN2ZkYjhjMjQ4YmU4MzNiYTE4ZmQyNQw Please revert the culprit, or disable the test(s) and find the appropriate owner to fix or delete. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r614212&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZGNmYTk5Mzg2ZDBiMGY5MTEwN2ZkYjhjMjQ4YmU4MzNiYTE4ZmQyNQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e092dc1b1477a1192745054d5885eb50cdfd8b2f commit e092dc1b1477a1192745054d5885eb50cdfd8b2f Author: Rakina Zata Amni <rakina@chromium.org> Date: Thu Dec 06 08:59:45 2018 Revert "Add console message in MixedContentChecker::HandleCertificateError" This reverts commit dcfa99386d0b0f91107fdb8c248be833ba18fd25. Reason for revert: Caused flaky tests: crbug.com/912431 Original change's description: > Add console message in MixedContentChecker::HandleCertificateError > > Print console message when subresources are loaded over broken HTTPS. > Screenshot: https://drive.google.com/file/d/1Sn_2c162NmvCoIXFuFVB68z-MhzphcNT/view?usp=sharing > > Bug: 587168 > Change-Id: I997a8da26f0fe015cc0103b96dcbaa7d40525eb8 > Reviewed-on: https://chromium-review.googlesource.com/c/1306779 > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614212} TBR=sky@chromium.org,meacer@chromium.org,yhirano@chromium.org,japhet@chromium.org,mkwst@chromium.org,livvielin@chromium.org Change-Id: I9142c895af7dd1c6a4c9ea7500ee0eca2ce9d118 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 587168, 912431 Reviewed-on: https://chromium-review.googlesource.com/c/1364974 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#614290} [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/chrome/browser/favicon/content_favicon_driver_browsertest.cc [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/renderer/core/loader/mixed_content_checker.cc [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-base-https-other-https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/fetch/serviceworker/thorough/scheme-blob-other-https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/mixed-autoupgrade/optionally/image-upgrade-console-message.https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/navigation/ping-cross-origin-from-https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/contentSecurityPolicy/register-bypassing-scheme-script.https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/active-subresource-in-iframe-blocked.https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/insecure-css-image-with-reload-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/insecure-css-resources-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/insecure-fetch-on-dedicated-worker-allowed.https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/insecure-fetch-on-dedicated-worker-blocked.https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/insecure-iframe-with-hsts.https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/mixedContent/strict-mode-image-in-frame-blocked.https-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/referrer-on-client-redirect-expected.txt [delete] https://crrev.com/8fea47aacf80c5e06dc7246a9b3673525cf14b62/third_party/blink/web_tests/http/tests/security/referrer-policy-attribute-img-no-referrer-when-downgrade-expected.txt [modify] https://crrev.com/e092dc1b1477a1192745054d5885eb50cdfd8b2f/third_party/blink/web_tests/http/tests/security/xssAuditor/report-script-tag-cross-origin-https-expected.txt
Revert fixed this, and going forward fixed with Issue 914679
Comment 1 by Findit
, Dec 6