New issue
Advanced search Search tips

Issue 912423 link

Starred by 11 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 463348



Sign in to add a comment

Gradient Backgrounds do not cover, leaving cracks with border-collapse: collapse

Reported by earnolma...@gmail.com, Dec 6

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36

Steps to reproduce the problem:
1. https://jsbin.com/vovedipuki/edit?html,output
2. Look at the menu items that are side by side in the HTML output window.  Notice a 1px separation between the menu items.  If you actually zoom in on this 1 x 50 pixel area with an image editor, you'll see an inverse gradient pattern acting as the border.

What is the expected behavior?
border-collapse should only affect table elements?  Whether or not its usage here is correct, it should not be affecting the rendering of the gradient backgrounds.  The problem doesn't seem to occur if you use a flat file as shown here:

https://jsbin.com/beraqazeno/edit?html,output

What went wrong?
Strange rendering of a 1px border showing separation between floated items when using a gradient background.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 71.0.3578.80  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Appears to render as expected in Firefox and IE.
 
Labels: Needs-Triage-M71
Repro note:
resize the middle splitter to the left so there are at least two buttons in a row
or use the simplified test.html attached below
Expected: no gap between
Observed: a vertical 1px gap between the elements

Bisected to r571505 = ae49f5caf2943049acab4abe802e82c8dc001184 = https://crrev.com/c/1112563 by schenney@chromium.org
"[PE] Improve background image painting"
Landed in 69.0.3477.0
test.html
234 bytes View Download
Cc: susan.boorgula@chromium.org
Components: Blink>Paint
Labels: -Type-Bug -Pri-2 Target-73 Triaged-ET FoundIn-73 Target-71 Target-72 RegressedIn-69 M-73 FoundIn-71 FoundIn-72 hasbisect OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: schenney@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Windows 10, Mac OS 10.13.6 and Ubuntu 14.04 on the latest Stable 71.0.3578.80 and latest Canary 73.0.3632.0.

Bisect Information:
====================
Good Build: 69.0.3476.0
Bad Build : 69.0.3477.0

As per comment #2, suspecting the below Change.
Reviewed-on: https://chromium-review.googlesource.com/1112563

schenney@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner.

Thanks...
Labels: -Pri-1 -Target-71 -Target-72 Pri-2
I'll get these fixed for M-73 branch.
Status: Started (was: Assigned)
Summary: Gradient Backgrounds do not cover, leaving cracks with border-collapse: collapse (was: border-collapse: collapse Producing Strange Border with Gradient Backgrounds)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c633d483b5e6777fe2ffc5cea93398083638f6e

commit 1c633d483b5e6777fe2ffc5cea93398083638f6e
Author: Stephen Chenney <schenney@chromium.org>
Date: Wed Dec 12 20:19:49 2018

Snap the snapped_dest_rect for backgrounds

For some reason the snapped_dest_rect for background image geometry
calculations was not actually snapped. Snapping it fixes cases where
we were not filling to the border without regressing any tests (in
fact improving some).

Probably fixes most of the background bugs resulting from the previous
big refactoring.

R=fmalita@chromium.org
BUG= 912423 , 889426 

Change-Id: Ieba65130e7f8c0e95db7375ab3a8188bfc78d8d5
Reviewed-on: https://chromium-review.googlesource.com/c/1372556
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616014}
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/renderer/core/paint/background_image_geometry.cc
[add] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-border-collapsed-gradient.html
[add] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-table-cells-zoomed.html
[add] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-border-collapsed-gradient-ref.html
[add] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-table-cells-zoomed-ref.html
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/fast/backgrounds/size/contain-and-cover-zoomed-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/paint/masks/fieldset-mask-expected.png
[add] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/paint/masks/fieldset-mask-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/backgrounds/background-tiling-sub-pixel-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/gradients/simple-gradients-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/inline/inline-box-background-repeat-y-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_layers-hide-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_layers-hide-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-row-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/tables/mozilla_expected_failures/other/test4-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/linux/virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_layers-hide-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_layers-hide-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-row-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_layers-hide-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_layers-hide-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-cell-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-column-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-column-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-column-group-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-row-collapsed-border-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93398083638f6e/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-row-expected.png
[modify] https://crrev.com/1c633d483b5e6777fe2ffc5cea93
Labels: Merge-Request-72
Verified in Canary 73.0.3639.0

Requesting a merge. The code change here is small and very safe. It fixes a lot of bugs (that I will dupe in shortly).
Cc: phanindra.mandapaka@chromium.org schenney@chromium.org
 Issue 890421  has been merged into this issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 13

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 463348
Let's target M73 for this. Is it urgent for M72? Seems like this has been around since 69. 
Cc: swarnasree.mukkala@chromium.org
 Issue 889426  has been merged into this issue.
It had 3 reports, and the only reason it wasn't fixed sooner was because I didn't have time. Given the simplicity of the fix, and the interest in getting it fixed I would still like to merge (the reporters have been nagging and apparently it affects Wikipedia, see comment #11).
Labels: -Merge-Review-72 Merge-Approved-72
Approving for M72, branch: 3626
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 17

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee2d276c187748923f193bf32de5b56e62595248

commit ee2d276c187748923f193bf32de5b56e62595248
Author: Stephen Chenney <schenney@chromium.org>
Date: Mon Dec 17 19:11:18 2018

Snap the snapped_dest_rect for backgrounds

M-72 merge

For some reason the snapped_dest_rect for background image geometry
calculations was not actually snapped. Snapping it fixes cases where
we were not filling to the border without regressing any tests (in
fact improving some).

Probably fixes most of the background bugs resulting from the previous
big refactoring.

R=fmalita@chromium.org
TBR=schenney@chromium.org
BUG= 912423 , 889426 

(cherry picked from commit 1c633d483b5e6777fe2ffc5cea93398083638f6e)

Change-Id: Ieba65130e7f8c0e95db7375ab3a8188bfc78d8d5
Reviewed-on: https://chromium-review.googlesource.com/c/1372556
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616014}
Reviewed-on: https://chromium-review.googlesource.com/c/1380576
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#400}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/renderer/core/paint/background_image_geometry.cc
[add] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-border-collapsed-gradient.html
[add] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-table-cells-zoomed.html
[add] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-border-collapsed-gradient-ref.html
[add] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-table-cells-zoomed-ref.html
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/flag-specific/enable-slimming-paint-v2/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/flag-specific/enable-slimming-paint-v2/paint/masks/fieldset-mask-expected.png
[add] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/flag-specific/enable-slimming-paint-v2/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/paint/masks/fieldset-mask-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/backgrounds/background-tiling-sub-pixel-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/gradients/simple-gradients-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/inline/inline-box-background-repeat-y-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_layers-hide-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_layers-hide-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/fast/table/backgr_simple-table-row-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/tables/mozilla_expected_failures/other/test4-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/linux/virtual/scalefactor150/fast/hidpi/static/calendar-picker-appearance-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_layers-hide-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_layers-hide-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.10/fast/table/backgr_simple-table-row-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/forms/calendar-picker/calendar-picker-appearance-zoom125-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_border-table-row-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_layers-hide-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_layers-hide-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_position-table-row-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-cell-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-cell-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-column-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-column-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-column-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-column-group-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-row-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-row-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11/fast/table/backgr_simple-table-row-group-collapsed-border-expected.png
[modify] https://crrev.com/ee2d276c187748923f193bf32de5b56e62595248/third_party/blink/web_tests/platform/mac-mac10.11
Status: Fixed (was: Started)
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ee2d276c187748923f193bf32de5b56e62595248

Commit: ee2d276c187748923f193bf32de5b56e62595248
Author: schenney@chromium.org
Commiter: schenney@chromium.org
Date: 2018-12-17 19:11:18 +0000 UTC

Snap the snapped_dest_rect for backgrounds

M-72 merge

For some reason the snapped_dest_rect for background image geometry
calculations was not actually snapped. Snapping it fixes cases where
we were not filling to the border without regressing any tests (in
fact improving some).

Probably fixes most of the background bugs resulting from the previous
big refactoring.

R=fmalita@chromium.org
TBR=schenney@chromium.org
BUG= 912423 , 889426 

(cherry picked from commit 1c633d483b5e6777fe2ffc5cea93398083638f6e)

Change-Id: Ieba65130e7f8c0e95db7375ab3a8188bfc78d8d5
Reviewed-on: https://chromium-review.googlesource.com/c/1372556
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616014}
Reviewed-on: https://chromium-review.googlesource.com/c/1380576
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#400}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment