Closure compile task_contoller_unittest |
||||
Issue description- add missing foreground/js/ui BUILD externs deps - remove the current html unittest - closure compile the code and the test
,
Dec 6
,
Dec 6
All test cases now call setupFileManagerPrivate(), we can move into Setup() as lucmult@ suggested ...
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96e0fd8bd99e572dca38519ae68140414636a21f commit 96e0fd8bd99e572dca38519ae68140414636a21f Author: Noel Gordon <noel@chromium.org> Date: Fri Dec 07 01:19:58 2018 task_contoller_unittest: move setupFileManagerPrivate() to Setup() After CL:1364270 all test cases begin with a setupFileManagerPrivate() call: move that into Setup(). No change in test behavior, no new tests. Bug: 912410 Change-Id: I36e2180012918ec00d552397395c8bb61048382c Reviewed-on: https://chromium-review.googlesource.com/c/1364996 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#614546} [modify] https://crrev.com/96e0fd8bd99e572dca38519ae68140414636a21f/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
,
Dec 7
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Dec 6