New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment
link

Issue 912410: Closure compile task_contoller_unittest

Reported by noel@chromium.org, Dec 6 Project Member

Issue description

- add missing foreground/js/ui BUILD externs deps
 - remove the current html unittest
 - closure compile the code and the test
 

Comment 1 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6afc4880a78e888a32df06df328386b1f7b31308

commit 6afc4880a78e888a32df06df328386b1f7b31308
Author: Noel Gordon <noel@chromium.org>
Date: Thu Dec 06 05:38:43 2018

Closure compile task_contoller_unittest

 - remove task_contoller_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - define, install, and use mockChrome in the unittest code
 - use setupFileManagerPrivate() in all test cases
   - testExecuteEntryTask had its own local version but the
     test could also jsut use the common one: make it so.
 - make all test cases use the createTaskController helper
   - update JsDoc: a {FileSelectionHandler} is now required
   - remove the crostini create helper function
   - remove crostini.init call: no test cases depend on the
     crostini volume manager fake.
   - make createTaskController call createCrostiniForTest()
     when new-ing the {TaskController}.
 - make MockFileSelectionHandler @constructor, and @extends
   {FileSelectionHandler} interface, so createTaskController
   construction is both simple and type-safe.
 - add decriptive comments for each test case fixture
 - fix all Closure compiler errors, and auto-format JS code

No change in test behavior, no new tests.

Bug:  912410 
Change-Id: I7a685533632860ce785b9aaca2e84b7c69579979
Reviewed-on: https://chromium-review.googlesource.com/c/1364270
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614276}
[modify] https://crrev.com/6afc4880a78e888a32df06df328386b1f7b31308/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/6afc4880a78e888a32df06df328386b1f7b31308/ui/file_manager/file_manager/foreground/js/BUILD.gn
[delete] https://crrev.com/ba4cf64ec6d7268f1a6922c39198f5b419cbac6f/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
[modify] https://crrev.com/6afc4880a78e888a32df06df328386b1f7b31308/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js

Comment 2 by noel@chromium.org, Dec 6

Status: Fixed (was: Started)

Comment 3 by noel@chromium.org, Dec 6

Status: Started (was: Fixed)
All test cases now call setupFileManagerPrivate(), we can move into Setup() as lucmult@ suggested ...

Comment 4 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96e0fd8bd99e572dca38519ae68140414636a21f

commit 96e0fd8bd99e572dca38519ae68140414636a21f
Author: Noel Gordon <noel@chromium.org>
Date: Fri Dec 07 01:19:58 2018

task_contoller_unittest: move setupFileManagerPrivate() to Setup()

After CL:1364270 all test cases begin with a setupFileManagerPrivate()
call: move that into Setup().

No change in test behavior, no new tests.

Bug:  912410 
Change-Id: I36e2180012918ec00d552397395c8bb61048382c
Reviewed-on: https://chromium-review.googlesource.com/c/1364996
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614546}
[modify] https://crrev.com/96e0fd8bd99e572dca38519ae68140414636a21f/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js

Comment 5 by noel@chromium.org, Dec 7

Status: Fixed (was: Started)

Sign in to add a comment