New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 912409: Always show shelf should not have rounded corner in splitscreen mode

Reported by minch@chromium.org, Dec 6 Project Member

Issue description

Chrome Version: 73.0.3631.0

What steps will reproduce the problem?
(1) Enter tablet mode and set shelf to "always show".
(2) Snap one window into splitscreen.


What is the expected result?
Shelf is visible with rounded corner.

What happens instead?
Shelf should not have the rounded corner.
 

Comment 1 by newcomer@chromium.org, Dec 10

Cc: manucornet@chromium.org
Actually manucornet@ might have a duplicate of this.

Comment 2 by minch@chromium.org, Dec 14

Status: Started (was: Assigned)

Comment 3 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d1c9d2a27fffc154593eac1c695fd041f64465

commit 23d1c9d2a27fffc154593eac1c695fd041f64465
Author: Min Chen <minch@google.com>
Date: Fri Dec 14 18:30:11 2018

shelf: Adjust the order of GetShelfBackgroundType.

Use SHELF_BACKGROUND_SPLIT_VIEW when both splitview and overview are
active. The background of the shelf will also influence the radius
corner of the shelf.

Bug:  912409 
Change-Id: I28643eface4a22422c24978686f7a50b01c7dba7
Reviewed-on: https://chromium-review.googlesource.com/c/1377431
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616753}
[modify] https://crrev.com/23d1c9d2a27fffc154593eac1c695fd041f64465/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/23d1c9d2a27fffc154593eac1c695fd041f64465/ash/shelf/shelf_layout_manager_unittest.cc

Comment 4 by minch@chromium.org, Dec 14

Status: Fixed (was: Started)

Sign in to add a comment