need gnlint to replace gyplint |
||||
Issue descriptionwe were supposed to have a gnlint script to make sure people were writing gn files correctly, but that seems to have been missed along the way. gyplint can be used to see what kind of checks we should have.
,
Dec 6
Assigning to yamaguchi@, who's actively working on gyp->gn migration now.
,
Jan 2
can we please prioritize this ? people are starting to reintroduce errors into the build that gyplint prevented. i'm fairly certain i mentioned a gnlint long before we started landing actual gn migrations.
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4255009e419efe1057ffcfe8009b03fde5a500d0 commit 4255009e419efe1057ffcfe8009b03fde5a500d0 Author: Mike Frysinger <vapier@chromium.org> Date: Mon Jan 07 20:07:56 2019 common-mk: tell people to stop using visibility_default No package should be using this helper. Add a note so hopefully new code won't start and until we have a proper gnlint to flag it. BUG=chromium:912393 TEST=precq passes Change-Id: I34bc9189b5a3f8e84f9cb8257eebe0a4e206becd Reviewed-on: https://chromium-review.googlesource.com/1393225 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> [modify] https://crrev.com/4255009e419efe1057ffcfe8009b03fde5a500d0/common-mk/BUILD.gn
,
Jan 9
|
||||
►
Sign in to add a comment |
||||
Comment 1 by vapier@chromium.org
, Dec 6