vr browser tests should be easier to run |
|||
Issue descriptionIt isn't obvious that you need to cd into out\Debug to run the tests. We could make the tests detect they are run in the correct directory, giving useful error messages. Alternatively (and better) we could derive the path to the fake openvr based on the path of the browser_test exe, so running in any directory works.
,
Dec 6
I have some spare cycles, and it looks like the code to get the executable path is already in Chromium, so I can take this.
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a58093bf1ff2b9320d6083dd27556045e8ef69d3 commit a58093bf1ff2b9320d6083dd27556045e8ef69d3 Author: bsheedy <bsheedy@chromium.org> Date: Fri Dec 07 18:19:14 2018 Make XR browser tests use executable-relative paths Makes the environment variable paths set by XR browser tests relative to the test binary's location instead of the current working directory. This makes the tests runnable from any directory instead of only from the output directory. Bug: 912392 Change-Id: I0f6ef8e2019add1457807b3d645d18e6b413b1de Reviewed-on: https://chromium-review.googlesource.com/c/1367101 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#614742} [modify] https://crrev.com/a58093bf1ff2b9320d6083dd27556045e8ef69d3/chrome/browser/vr/test/xr_browser_test.cc
,
Dec 7
|
|||
►
Sign in to add a comment |
|||
Comment 1 by billorr@chromium.org
, Dec 6