New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: ChromeVoxEventWatcherUnitTest.ButtonFocusFeedback
Team-Accessibility

Blocking:
issue 622387



Sign in to add a comment
link

Issue 912390: ChromeVoxEventWatcherUnitTest.ButtonFocusFeedback is flaky

Reported by Findit, Dec 6 Project Member

Issue description

Comment 1 by dtapu...@chromium.org, Dec 6

Components: UI>Accessibility>ChromeVox

Comment 2 by jyasskin@chromium.org, Dec 6

Owner: danakj@chromium.org
Status: Assigned (was: Untriaged)
Dana, could you make sure someone owns re-enabling these ChromeVox tests? I'll disable them as your CL requests.

Comment 3 by danakj@chromium.org, Dec 6

Blocking: 622387
Cc: danakj@chromium.org
Owner: dmazz...@chromium.org
It's my understanding that these are already flaky and it's been known since at least 2015 [1]. so I think these tests are not maintained and I'm not honestly sure what to do with that. But I don't think it's reasonable to say that we can't change any timing in content because of these tests either so...yeah here we are.

I will assign this to dmazzoni@ as well like the metabug [2], and block it on this.

dmazzoni@ what are your thoughts on this?

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=498881
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=622387

Comment 4 by jyasskin@chromium.org, Dec 6

 Issue 912014  has been merged into this issue.

Comment 5 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6af09c65d9c1cc347f08573eda20c25e49765bd6

commit 6af09c65d9c1cc347f08573eda20c25e49765bd6
Author: Jeffrey Yasskin <jyasskin@chromium.org>
Date: Thu Dec 06 21:35:31 2018

Disable flaky ChromeVox tests.

These started flaking with https://crrev.com/613661 which changed timing
in the renderer process.

Bug: 912390
Change-Id: Ia41f0dc73210d83b2562f9ff55e9a7407d102448
Tbr: dmazzoni@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1366360
Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614496}
[modify] https://crrev.com/6af09c65d9c1cc347f08573eda20c25e49765bd6/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

Comment 6 by fhorschig@chromium.org, Dec 11

Labels: -Sheriff-Chromium
Test disabled and bug assigned, remove from sheriff queueueue.

Comment 7 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f326f2b3fdb13584493bb594ad07da5f85c02c23

commit f326f2b3fdb13584493bb594ad07da5f85c02c23
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Tue Dec 11 11:53:42 2018

[ChromeOS][Flaky] Disable three flaky ChromeVox tests

This CL disabled these flaky tests:
TextFocusFeedback
DoubleFocusAlertDialogFeedback
ToggleOnKeyUp

They have caused failures recently and show a history of flakiness:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeVoxEventWatcherUnitTest

TBR=dmazzoni@chromium.org

Bug: 912390, 622387
Change-Id: If7647be13420ff98df3a51d0fa156635f181c074
Reviewed-on: https://chromium-review.googlesource.com/c/1371476
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615495}
[modify] https://crrev.com/f326f2b3fdb13584493bb594ad07da5f85c02c23/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

Comment 8 by droger@chromium.org, Dec 17

ChromeVoxEventWatcherUnitTest.EditableText is flaky

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-
rel/17386

Comment 9 by bugdroid1@chromium.org, Dec 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14bdf67df8e5c1d824483fe909058ae28d60db4b

commit 14bdf67df8e5c1d824483fe909058ae28d60db4b
Author: David Roger <droger@chromium.org>
Date: Mon Dec 17 15:11:21 2018

Disable flaky ChromeVoxEventWatcherUnitTest.EditableText

TBR=dmazzoni

Bug: 912390
Change-Id: I427d4cd3c1c9936ba906b50702b94e069cb75d1a
Reviewed-on: https://chromium-review.googlesource.com/c/1379959
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617115}
[modify] https://crrev.com/14bdf67df8e5c1d824483fe909058ae28d60db4b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs

Comment 10 by droger@chromium.org, Dec 17

 Issue 915688  has been merged into this issue.

Sign in to add a comment