New issue
Advanced search Search tips

Issue 912375 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Dark mode] Update colors for seperators and icons in Secondary UI

Project Member Reported by namratakannan@chromium.org, Dec 5

Issue description

1. Update icon colors displayed in Secondary UI such as user menu to GG500
2. Update the color of the separator to GG800,80%
3. Update button colors to follow
   spec:https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit#slide=id.g471d243f08_0_559


 
Screen Shot 2018-12-05 at 3.14.02 PM.png
76.5 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1983a2170977184ff81c1621833a214eb779d42a

commit 1983a2170977184ff81c1621833a214eb779d42a
Author: Leonard Grey <lgrey@chromium.org>
Date: Thu Dec 20 23:41:08 2018

Dark mode secondary UI spec/refinements

This change:
- Mostly implements UX's secondary UI spec
- Switches topchrome to use the same colors as incognito, though
this may be temporary
- Replaces some temp colors

Bug: 912375, 850098

Change-Id: I447c3062455330b01c0e7381d3a9eabd2709a970
Reviewed-on: https://chromium-review.googlesource.com/c/1378408
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618375}
[modify] https://crrev.com/1983a2170977184ff81c1621833a214eb779d42a/chrome/browser/themes/theme_properties.cc
[modify] https://crrev.com/1983a2170977184ff81c1621833a214eb779d42a/chrome/browser/ui/views/chrome_typography_provider.cc
[modify] https://crrev.com/1983a2170977184ff81c1621833a214eb779d42a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/1983a2170977184ff81c1621833a214eb779d42a/ui/native_theme/common_theme.cc
[modify] https://crrev.com/1983a2170977184ff81c1621833a214eb779d42a/ui/native_theme/native_theme_mac.mm
[modify] https://crrev.com/1983a2170977184ff81c1621833a214eb779d42a/ui/views/bubble/footnote_container_view.cc
[modify] https://crrev.com/1983a2170977184ff81c1621833a214eb779d42a/ui/views/controls/button/md_text_button.cc

Sign in to add a comment