New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 912368 link

Starred by 0 users
Status: Assigned
Owner:
paulmiller@chromium.org
Cc:
paulmiller@chromium.org
asvitk...@chromium.org
changwan@chromium.org
skare@chromium.org
isherman@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: 2019-05-01
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove kVariationsPermutedEntropyCache

Project Member Reported by paulmiller@chromium.org, Dec 5 
For https://crbug.com/890413, CachingPermutedEntropyProvider is being removed in favor of NormalizedMurmurHashEntropyProvider. We should clear the cache from prefs, and then remove the pref name after a few milestones. Arbitrarily setting NextAction to May 2019 in time for m76.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4267fbbca666a8a354f01bf905adfdc0d917f1a

commit c4267fbbca666a8a354f01bf905adfdc0d917f1a
Author: Paul Miller <paulmiller@google.com>
Date: Thu Jan 03 03:20:35 2019

Remove (Caching)PermutedEntropyProvider

It's been replaced by NormalizedPermutingEntropyProvider; see commits
7c0efea0a6 and 4355667974.

BUG=890413,912368

Change-Id: I962ecdde976f84c0cdadfb6c1a36a3d12246fb0b
Reviewed-on: https://chromium-review.googlesource.com/c/1388287
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619573}
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/metrics/metrics_service.h
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/metrics/metrics_state_manager.cc
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/metrics/metrics_state_manager_unittest.cc
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/variations/BUILD.gn
[delete] https://crrev.com/4675eb4b376d0f9b5591fabadb2c61b78c30c3f4/components/variations/caching_permuted_entropy_provider.cc
[delete] https://crrev.com/4675eb4b376d0f9b5591fabadb2c61b78c30c3f4/components/variations/caching_permuted_entropy_provider.h
[delete] https://crrev.com/4675eb4b376d0f9b5591fabadb2c61b78c30c3f4/components/variations/caching_permuted_entropy_provider_unittest.cc
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/variations/entropy_provider.cc
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/variations/entropy_provider.h
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/variations/entropy_provider_unittest.cc
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/variations/pref_names.cc
[modify] https://crrev.com/c4267fbbca666a8a354f01bf905adfdc0d917f1a/components/variations/proto/BUILD.gn
[delete] https://crrev.com/4675eb4b376d0f9b5591fabadb2c61b78c30c3f4/components/variations/proto/permuted_entropy_cache.proto
►

Sign in to add a comment