New issue
Advanced search Search tips

Issue 912367 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 793092
issue 922153


Participants' hotlists:
chrome-client-infra-backlog


Sign in to add a comment

Rethink and unify ios and chromium builder / test configs

Project Member Reported by sergeybe...@chromium.org, Dec 5

Issue description

This is an umbrella issue for a large-scale project of revamping many of the configs that go into defining what a builder runs.

In scope:
- mb_config.pyl
- testing/buildbot/*.pyl
- recipe-side configs, both config.py scripts in the recipe modules, and various by-master configs defining which config.py settings to apply for which builders.
- possibly some LUCI config bits, if there is duplication of settings.
- ios/build/bots configs

Out of scope:
- proper LUCI configs for the services. These are tracked in issue 833946.

 
Labels: -Restrict-View-Google
Current very preliminary thought: to use starlark and follow similar design idea as for lucicfg, but generate configs consumed by the recipes.

In particular, this may require redesigning the recipes to read a bulk of their configs from chromium/src, instead of having those recipe-side in build.git.
Components: -Infra>Client>Infra Infra>Client>Chrome
I'm getting close to the point of just converting ios to the existing chromium configs, independently of the config work elsewhere.
Re: #3 - I'm not opposed to that, but it may degrade the config experience for the ios folks until this effort is finished. I was hoping to avoid that.
Yeah, and I understand that POV, but I'm coming to view that as less and less of a blocker given the ongoing maintenance burden presented by the uniqueness of ios's current infra configuration.
Filed issue 912681 to track the ios -> chromium migration. I'd like to keep this bug focused on configs.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/experimental/+/6a4ed8b60e3282ad9ea55916a2080fa3307d4f4a

commit 6a4ed8b60e3282ad9ea55916a2080fa3307d4f4a
Author: Sergey Berezin <sergeyberezin@google.com>
Date: Fri Dec 07 00:40:54 2018

Set up a directory for experimenting with chromium configs

Bug: 912367
Change-Id: Id322851df9743a6e9f2eb054874aaa62e215bed2
Reviewed-on: https://chromium-review.googlesource.com/c/1366917
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>

[add] https://crrev.com/6a4ed8b60e3282ad9ea55916a2080fa3307d4f4a/sergeyberezin/build_configs/README.md

Blocking: 793092
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/experimental/+/83f3bbd84daa51bac46c4a54ad7ed47a48c24354

commit 83f3bbd84daa51bac46c4a54ad7ed47a48c24354
Author: Sergey Berezin <sergeyberezin@google.com>
Date: Wed Dec 19 03:07:15 2018

Add a primitive lucicfg module and config

The intent is to test how a simple graph-based config can be created from the
first principles using lucicfg.

Bug: 912367
Change-Id: I5d93bbb7d00ed708e3be757e3413ed213f999d6f
Reviewed-on: https://chromium-review.googlesource.com/c/1382628
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>

[add] https://crrev.com/83f3bbd84daa51bac46c4a54ad7ed47a48c24354/sergeyberezin/build_configs/test.star
[add] https://crrev.com/83f3bbd84daa51bac46c4a54ad7ed47a48c24354/sergeyberezin/build_configs/chromium.star

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/experimental/+/2f42c57d2a0ba9bfd65db8b3c4f67744b6fd5156

commit 2f42c57d2a0ba9bfd65db8b3c4f67744b6fd5156
Author: Sergey Berezin <sergeyberezin@google.com>
Date: Fri Dec 21 01:18:57 2018

[builder_configs] Add a starter script to convert existing configs.

Also, update the list of targets from the actual waterfalls.pyl.

Bug: 912367
Change-Id: Ia6b106bcf9906c0427d94aa09171bfc76fd4c6da
Reviewed-on: https://chromium-review.googlesource.com/c/1387848
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>

[modify] https://crrev.com/2f42c57d2a0ba9bfd65db8b3c4f67744b6fd5156/sergeyberezin/build_configs/targets/targets.star
[add] https://crrev.com/2f42c57d2a0ba9bfd65db8b3c4f67744b6fd5156/sergeyberezin/build_configs/convert_configs.py

Labels: Pri-2
Setting defect without priority to default.
Blocking: 922153

Sign in to add a comment