New issue
Advanced search Search tips

Issue 912365 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Extensions Click-to-Script: Adjust UI for activeTab extensions

Project Member Reported by rdevlin....@chromium.org, Dec 5

Issue description

If an extension has activeTab (and no other host permissions), it is essentially always running in "on click" mode.  We should properly reflect that in the UI, rather than only looking at withheld/granted host permissions.  This way, when a user right clicks on the icon and sees the context menu, the mode should be "on click", rather than "can't access this site" (which would be wrong for an activeTab extension).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c02de651559d1095bdf03062dc8bf3d26831f29c

commit c02de651559d1095bdf03062dc8bf3d26831f29c
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Sat Dec 08 02:51:03 2018

[Extensions Click-to-Script] Adjust context menu options pt 2

Make two additional changes to the runtime host permissions controls in
an extension's context menu:
- Always show all access options (on click, on this site, on all urls,
  and learn more) if the extension can access the site at all (if the
  extension cannot access the site, the "can't access this site" item is
  shown instead). If an extension can't always run on the site or on all
  sites, disable those options rather than removing them from the menu.
- Consider activeTab as running "on click". This fixes a contradiction
  where before activeTab extensions would say "can't access this site",
  even though they could if the user invoked them. ActiveTab extensions
  cannot be changed out of the on-click mode.

Bug: 912365

Change-Id: Ia443755df7d9a995433e81240739581f0021ded1
Reviewed-on: https://chromium-review.googlesource.com/c/1363950
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614930}
[modify] https://crrev.com/c02de651559d1095bdf03062dc8bf3d26831f29c/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/c02de651559d1095bdf03062dc8bf3d26831f29c/chrome/browser/extensions/extension_context_menu_model.h
[modify] https://crrev.com/c02de651559d1095bdf03062dc8bf3d26831f29c/chrome/browser/extensions/extension_context_menu_model_unittest.cc

Sign in to add a comment