performance measures with the same name are reported incorrectly in the trace |
||
Issue description
If the page uses performance.measure with the same measure name, trace events are misreported, which lead to incorrect rendering in the devtools timeline (and tracing UI)
For example:
setTimeout(_ => performance.mark('astart'), 0);
setTimeout(_ => performance.mark('aend'), 100);
setTimeout(_ => performance.mark('bstart'), 20);
setTimeout(_ => performance.mark('bend'), 220);
setTimeout(_ => performance.mark('cstart'), 40);
setTimeout(_ => performance.mark('cend'), 41);
setTimeout(_ => {
performance.measure('timespan', 'astart', 'aend');
performance.measure('timespan', 'bstart', 'bend');
performance.measure('timespan', 'cstart', 'cend');
}, 250);
This should report measure of length ~100ms, ~200ms, and 1ms,
However, currently we see measures of: ~220, ~80ms, and 1ms.
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e4f35ef10df237ec8c34460552a6366058b763b commit 3e4f35ef10df237ec8c34460552a6366058b763b Author: Paul Irish <paulirish@chromium.org> Date: Fri Dec 07 01:59:50 2018 Build hash for PerformanceMeasureEntry trace event with start/end times Bug: 912363 Change-Id: I33dfc873765de17ca6f30db850093337f89da5bd Reviewed-on: https://chromium-review.googlesource.com/c/1359865 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#614575} [modify] https://crrev.com/3e4f35ef10df237ec8c34460552a6366058b763b/third_party/blink/renderer/core/timing/performance_user_timing.cc [modify] https://crrev.com/3e4f35ef10df237ec8c34460552a6366058b763b/third_party/blink/renderer/devtools/front_end/performance_test_runner/TimelineTestRunner.js [add] https://crrev.com/3e4f35ef10df237ec8c34460552a6366058b763b/third_party/blink/web_tests/http/tests/devtools/tracing/user-timing-expected.txt [add] https://crrev.com/3e4f35ef10df237ec8c34460552a6366058b763b/third_party/blink/web_tests/http/tests/devtools/tracing/user-timing.js
,
Dec 7
,
Dec 18
|
||
►
Sign in to add a comment |
||
Comment 1 by paulir...@chromium.org
, Dec 5