RasterInvalidator tests fail with BlinkGenPropertyTrees enabled |
|||
Issue descriptionThese tests fail with BGPT enabled: RasterInvalidatorTest.ClipPropertyChangeRounded DisplayItemRasterInvalidatorTest.SwapOrderCrossingChunks RasterInvalidatorTest.ClipLocalTransformSpaceChangeNoInvalidation RasterInvalidatorTest.EffectLocalTransformSpaceChangeNoInvalidation (see: https://chromium-review.googlesource.com/c/chromium/src/+/1363207)
,
Dec 5
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dedab04b5256f88ec4dbbbae9492941e8cf1221a commit dedab04b5256f88ec4dbbbae9492941e8cf1221a Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Dec 06 02:00:06 2018 [BlinkGenPropertyTrees] Fix raster invalidation test We need to explicitly clear property tree changed state for BGPT because it is not done during PaintController::FinishCycle(). Bug: 912330 Change-Id: I32c9a110f75eb92e0af9c62ab9dbed824b57aeb1 Reviewed-on: https://chromium-review.googlesource.com/c/1363979 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#614231} [modify] https://crrev.com/dedab04b5256f88ec4dbbbae9492941e8cf1221a/third_party/blink/renderer/platform/graphics/paint/display_item_raster_invalidator_test.cc [modify] https://crrev.com/dedab04b5256f88ec4dbbbae9492941e8cf1221a/third_party/blink/renderer/platform/graphics/paint/raster_invalidator_test.cc
,
Dec 6
,
Dec 6
Thanks for the quick fix! This was blocking enabling BGPT and fixing it will help us turn on BGPT today. |
|||
►
Sign in to add a comment |
|||
Comment 1 by pdr@chromium.org
, Dec 5