New issue
Advanced search Search tips

Issue 912303 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 905052



Sign in to add a comment

[Autofill Sync] Display row in dropdown

Project Member Reported by tmartino@chromium.org, Dec 5

Issue description

The dropdown should show a row disclosing where Sync Transport cards come from.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd9aeea14a4514e500ee33891f019b6322ac565c

commit bd9aeea14a4514e500ee33891f019b6322ac565c
Author: Tommy Martino <tmartino@chromium.org>
Date: Fri Dec 07 16:06:03 2018

[Autofill Sync] Adding option to dropdown

This CL adds a new option to the Autofill dropdown footer. This consists
of:

* Changes to components/autofill to include the row as a suggestion
  under the appropriate conditions.

* Changes to the native popup views to display properly if only footer
  rows are present. (This was not possible before the introduction of
  the new row type.)

* Updates to the autofill_popup_layout_model to return a Google "G" logo
  as one of the possible icons.

* Moves a Google "G" logo vector icon to be available on platforms other
  than Mac.

Bug:  912303 
Change-Id: Idc03d7eccc1d9ea371ece79475b0b6e738ce0853
Reviewed-on: https://chromium-review.googlesource.com/c/1356199
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614711}
[modify] https://crrev.com/bd9aeea14a4514e500ee33891f019b6322ac565c/chrome/app/vector_icons/BUILD.gn
[modify] https://crrev.com/bd9aeea14a4514e500ee33891f019b6322ac565c/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/bd9aeea14a4514e500ee33891f019b6322ac565c/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/bd9aeea14a4514e500ee33891f019b6322ac565c/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/bd9aeea14a4514e500ee33891f019b6322ac565c/components/autofill/core/browser/autofill_external_delegate.h
[modify] https://crrev.com/bd9aeea14a4514e500ee33891f019b6322ac565c/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/bd9aeea14a4514e500ee33891f019b6322ac565c/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/bd9aeea14a4514e500ee33891f019b6322ac565c/components/autofill/core/browser/autofill_manager.h

Labels: butter-hotlist
Labels: -Pri-3 Pri-1
Updating the priority, I assume it was just left on the default? :)
Status: Fixed (was: Started)
Labels: Merge-Request-72
Status: Verified (was: Fixed)
Verified in Canary; requesting merge.

This CL addresses UI and privacy/disclosure concerns for Sync Transport for Autofill Payments. Some of these concerns were raised quite recently thanks to feedback received during and after the DICE launch.
Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87548235015f88f1db19044692ed634190437a9

commit b87548235015f88f1db19044692ed634190437a9
Author: Tommy Martino <tmartino@chromium.org>
Date: Wed Dec 12 22:59:31 2018

[Merge 72] [Autofill Sync] Adding option to dropdown

This CL adds a new option to the Autofill dropdown footer. This consists
of:

* Changes to components/autofill to include the row as a suggestion
  under the appropriate conditions.

* Changes to the native popup views to display properly if only footer
  rows are present. (This was not possible before the introduction of
  the new row type.)

* Updates to the autofill_popup_layout_model to return a Google "G" logo
  as one of the possible icons.

* Moves a Google "G" logo vector icon to be available on platforms other
  than Mac.

TBR=sebsg@chromium.org

Bug:  912303 
Change-Id: Idc03d7eccc1d9ea371ece79475b0b6e738ce0853
Reviewed-on: https://chromium-review.googlesource.com/c/1356199
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614711}(cherry picked from commit bd9aeea14a4514e500ee33891f019b6322ac565c)
Reviewed-on: https://chromium-review.googlesource.com/c/1374146
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#312}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/b87548235015f88f1db19044692ed634190437a9/chrome/app/vector_icons/BUILD.gn
[modify] https://crrev.com/b87548235015f88f1db19044692ed634190437a9/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/b87548235015f88f1db19044692ed634190437a9/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/b87548235015f88f1db19044692ed634190437a9/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/b87548235015f88f1db19044692ed634190437a9/components/autofill/core/browser/autofill_external_delegate.h
[modify] https://crrev.com/b87548235015f88f1db19044692ed634190437a9/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/b87548235015f88f1db19044692ed634190437a9/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/b87548235015f88f1db19044692ed634190437a9/components/autofill/core/browser/autofill_manager.h

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/b87548235015f88f1db19044692ed634190437a9

Commit: b87548235015f88f1db19044692ed634190437a9
Author: tmartino@chromium.org
Commiter: tmartino@chromium.org
Date: 2018-12-12 22:59:31 +0000 UTC

[Merge 72] [Autofill Sync] Adding option to dropdown

This CL adds a new option to the Autofill dropdown footer. This consists
of:

* Changes to components/autofill to include the row as a suggestion
  under the appropriate conditions.

* Changes to the native popup views to display properly if only footer
  rows are present. (This was not possible before the introduction of
  the new row type.)

* Updates to the autofill_popup_layout_model to return a Google "G" logo
  as one of the possible icons.

* Moves a Google "G" logo vector icon to be available on platforms other
  than Mac.

TBR=sebsg@chromium.org

Bug:  912303 
Change-Id: Idc03d7eccc1d9ea371ece79475b0b6e738ce0853
Reviewed-on: https://chromium-review.googlesource.com/c/1356199
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614711}(cherry picked from commit bd9aeea14a4514e500ee33891f019b6322ac565c)
Reviewed-on: https://chromium-review.googlesource.com/c/1374146
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#312}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment