Make /Computers machine roots read only in files app |
||||||
Issue descriptionDriveFS currently does not enforce machine roots as being readonly, so if users try and write there DriveFS has a bad time. We should be able to at least prevent people trying to write files there in the files app as an initial precaution.
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e4d0f2963c868db95bce4b4d2505f457c6d0a50 commit 3e4d0f2963c868db95bce4b4d2505f457c6d0a50 Author: Stuart Langley <slangley@google.com> Date: Wed Dec 05 23:06:52 2018 Make machine roots read only. This should be enforced by DriveFS, but currently they have a bug so we can do the same thing in the files app, by marking the individual computer roots as read only. Bug: 912287 Change-Id: I6df7c598315000fb87a221fd530545298cdb2ce1 Reviewed-on: https://chromium-review.googlesource.com/c/1363731 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#614160} [modify] https://crrev.com/3e4d0f2963c868db95bce4b4d2505f457c6d0a50/ui/file_manager/file_manager/background/js/volume_manager_impl.js [modify] https://crrev.com/3e4d0f2963c868db95bce4b4d2505f457c6d0a50/ui/file_manager/file_manager/background/js/volume_manager_unittest.js
,
Dec 5
,
Dec 6
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82ea17e0d944d870ec7b5a6dedc54f2215d5e90e commit 82ea17e0d944d870ec7b5a6dedc54f2215d5e90e Author: Stuart Langley <slangley@google.com> Date: Thu Dec 06 23:44:59 2018 Make machine roots read only. This should be enforced by DriveFS, but currently they have a bug so we can do the same thing in the files app, by marking the individual computer roots as read only. Bug: 912287 Change-Id: I6df7c598315000fb87a221fd530545298cdb2ce1 Reviewed-on: https://chromium-review.googlesource.com/c/1363731 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614160}(cherry picked from commit 3e4d0f2963c868db95bce4b4d2505f457c6d0a50) Reviewed-on: https://chromium-review.googlesource.com/c/1366488 Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#126} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/82ea17e0d944d870ec7b5a6dedc54f2215d5e90e/ui/file_manager/file_manager/background/js/volume_manager_impl.js [modify] https://crrev.com/82ea17e0d944d870ec7b5a6dedc54f2215d5e90e/ui/file_manager/file_manager/background/js/volume_manager_unittest.js
,
Dec 7
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82ea17e0d944d870ec7b5a6dedc54f2215d5e90e Commit: 82ea17e0d944d870ec7b5a6dedc54f2215d5e90e Author: slangley@google.com Commiter: slangley@chromium.org Date: 2018-12-06 23:44:59 +0000 UTC Make machine roots read only. This should be enforced by DriveFS, but currently they have a bug so we can do the same thing in the files app, by marking the individual computer roots as read only. Bug: 912287 Change-Id: I6df7c598315000fb87a221fd530545298cdb2ce1 Reviewed-on: https://chromium-review.googlesource.com/c/1363731 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614160}(cherry picked from commit 3e4d0f2963c868db95bce4b4d2505f457c6d0a50) Reviewed-on: https://chromium-review.googlesource.com/c/1366488 Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#126} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by slangley@chromium.org
, Dec 5