New issue
Advanced search Search tips

Issue 912272 link

Starred by 1 user

Issue metadata

Status: ExternalDependency
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

First Gerrit review request email was sent with incorrect email

Project Member Reported by c...@chromium.org, Dec 5

Issue description

On https://crrev.com/c/1362477, we had an issue where I got an email about a new CL with a request for another dev to review.  After getting pinged by a dev letting me know about the review request, I noticed I was actually requested to review at that time, too.  The email I received earlier implied that I was only cc'd on the CL and not asked to review, which led to me missing the request.

We think these steps should reproduce the problem:
(1) Find another dev to help you test this bug.
(2) Create a CL with R=<otherdev@chromium.org> in commit message.
(3) Upload CL to chromium-reviews.
(4) Open CL in browser, verify that CL has "R=<otherdev@chromium.org>" in commit message and that otherdev@chromium.org appears as a reviewer.
(5) Click REPLY to open notification screen.
(6) Verify that otherdev@chromium.org appears in reviewers line.  Add someone else to reviewers and submit.
(7) Verify that otherdev@ gets email for CL.

What is the expected result?

otherdev@'s email about this CL should read "First Developer would like Other Developer and Someone Else to review this change."

What happens instead?

otherdev@'s email about this CL reads "First Developer would like Someone Else to review this change."
 
Components: -Infra Infra>Codereview>Gerrit
It seems like all the reviewers are correctly added to the change and that this is just about the generated email. The emails are all from soy templates in Gerrit itself. Will take some time to figure out where I should send this to get to the right folks on Gerrit.
Status: Closed (was: Untriaged)
Moved this to buganizer where the appropriate Gerrit team tracks their work, cc'ing everyone currently on this issue. 

https://b.corp.google.com/issues/120613456

I'm going to close this version of the bug, effectively now a dupe.
@ajp, do you have any objection to keeping this crbug open with status ExternalDependency until gerrit fixes the issue?

Leaving it open would make it clear that the issue is still happening and might make it easier for others that run into it.
Status: ExternalDependency (was: Closed)
Re-opening for now.

Sign in to add a comment