Issue metadata
Sign in to add a comment
|
DFMs: Module don't get emulated |
||||||||||||||||||||||||||
Issue descriptionRequesting the AR or VR DFM never results in a module install. The culprit is 72fae848f66d6032233e4fc5380a6258d630bb95. More specifically, we cannot call SplitInstallManagerFactory.create(-).getInstalledModules() before SplitCompat.install(-).
,
Dec 7
,
Dec 7
This has been verified in Canary by tiborg@ and myself.
,
Dec 7
Approving merge to M72 branch 3626 based on comment #3 and per offline chat with benmason@. Pls merge ASAP. Thank you.
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cc6c373ce9b85b2454a7e7dd9a2a883b4361384 commit 8cc6c373ce9b85b2454a7e7dd9a2a883b4361384 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Dec 07 21:42:24 2018 [modules] Make sure splitcompat called before querying emulated modules This fixes a bug where on-demand modules never get emulated. Bug: 912214 Change-Id: Ia44aab425e3f83c4f22c5d397bbbcd92e7fe2138 Reviewed-on: https://chromium-review.googlesource.com/c/1363680 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614041}(cherry picked from commit 6f8ab209d7d3c22c27f35f0d075a2230ba53bc40) Reviewed-on: https://chromium-review.googlesource.com/c/1368769 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#153} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/8cc6c373ce9b85b2454a7e7dd9a2a883b4361384/components/module_installer/android/java/src-impl/org/chromium/components/module_installer/ModuleInstaller.java
,
Dec 7
,
Dec 10
The NextAction date has arrived: 2018-12-10
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cc6c373ce9b85b2454a7e7dd9a2a883b4361384 Commit: 8cc6c373ce9b85b2454a7e7dd9a2a883b4361384 Author: tiborg@chromium.org Commiter: tiborg@chromium.org Date: 2018-12-07 21:42:24 +0000 UTC [modules] Make sure splitcompat called before querying emulated modules This fixes a bug where on-demand modules never get emulated. Bug: 912214 Change-Id: Ia44aab425e3f83c4f22c5d397bbbcd92e7fe2138 Reviewed-on: https://chromium-review.googlesource.com/c/1363680 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614041}(cherry picked from commit 6f8ab209d7d3c22c27f35f0d075a2230ba53bc40) Reviewed-on: https://chromium-review.googlesource.com/c/1368769 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#153} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 5