Issue metadata
Sign in to add a comment
|
window.chrome.webstore is 'undefined'
Reported by
danylo.l...@gmail.com,
Dec 5
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36 Steps to reproduce the problem: Insert the following snippet into the script or a Dev Tools console. (typeof InstallTrigger !== 'undefined') ? 'firefox' : (!!window.chrome && !!window.chrome.webstore) ? 'chrome' : null; It returns 'null'. The cause of this one is the issue with the 'window.chrome.webstore', which is undefined in Chrome 71, but works in Chrome 70. This API is not marked as deprecated and not mentioned in release notes, so this should be a bug. What is the expected behavior? The expected behavior is to return 'chrome' string, so this snippet will properly detect Chrome What went wrong? Snippet returns 'null', because window.chrome.webstore is undefined Did this work before? Yes 70 Does this work in other browsers? Yes Chrome version: 71.0.3578.80 Channel: stable OS Version: 10.0 Flash Version:
,
Dec 5
It was supported for inline installations and once that feature got removed, there was no purpose for chrome.webstore, so it was removed as well, albeit with no specific announcement. However, that is kind of what you get when browser sniffing using features (feels like the document.all-to-detect-Internet-Explorer of the 2010s with Chrome), so I would not count on it being reverted. You better change your code.
,
Dec 5
Quoting the documentation https://developer.chrome.com/webstore/inline_installation Important: As of 06/12/2018, inline installation is deprecated. For more information, read our Chromium Blog post [1] and Migration FAQ [2]. [1]: https://blog.chromium.org/2018/06/improving-extension-transparency-for.html [2]: https://developer.chrome.com/extensions/inline_faq Quoting [1]: In early December 2018, the inline install API method will be removed from Chrome 71.
,
Dec 6
,
Dec 6
It looks like the present behavior as WAI. As per comment#3 CC'ing jawag@ to provide further inputs on the issue. Thanks.!
,
Dec 6
As mentioned in #2 and #3, this is WAI. Since inline installation is removed, so is the chrome.webstore property. For detecting browser, you could look at the user agent string? |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmenke@chromium.org
, Dec 5