Port sync_auth_test.cc to use IdentityManager instead of ProfileOAuth2TokenService |
||
Issue descriptionThis will require bringing up an identity_test_utils.h equivalent to PO2TS::set_max_authorization_token_fetch_retries_for_testing(). We can call it DisableAccessTokenFetchRetries(), since its only usage in the codebase on PO2TS is here and the value passed is 0.
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c3ca3a11d98ece6a40592b0eadbf8a84e96e80a commit 3c3ca3a11d98ece6a40592b0eadbf8a84e96e80a Author: Sergio Villar Senin <svillar@igalia.com> Date: Thu Jan 03 10:41:03 2019 Port sync_auth_test.cc to use IdentityManager instead of PO2TS A new function has to be added to identity_test_utils in order to set the maximum number of authentication token fetch retries to 0, i.e., to disable retries. Bug: 912171 Change-Id: I7f39f8b0aec5c180a92a2b26cb3e6a73f58645b1 Reviewed-on: https://chromium-review.googlesource.com/c/1386791 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#619612} [modify] https://crrev.com/3c3ca3a11d98ece6a40592b0eadbf8a84e96e80a/chrome/browser/sync/test/integration/sync_auth_test.cc [modify] https://crrev.com/3c3ca3a11d98ece6a40592b0eadbf8a84e96e80a/services/identity/public/cpp/identity_manager.h [modify] https://crrev.com/3c3ca3a11d98ece6a40592b0eadbf8a84e96e80a/services/identity/public/cpp/identity_test_utils.cc [modify] https://crrev.com/3c3ca3a11d98ece6a40592b0eadbf8a84e96e80a/services/identity/public/cpp/identity_test_utils.h
,
Jan 3
|
||
►
Sign in to add a comment |
||
Comment 1 by svil...@igalia.com
, Dec 20Status: Started (was: Available)