New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment
link

Issue 912170: ☂ Convert uses of AccountTrackerService::FindAccountInfoBy{Email,GaiaId} to IdentityManager

Reported by sdefresne@chromium.org, Dec 5 Project Member

Issue description

First need to add the following two methods:
- GetAccountInfoForAccountWithRefreshTokenByEmail
- GetAccountInfoForAccountWithRefreshTokenByGaiaId

Then we can convert code to the new API
 

Comment 1 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d37fb92c058ad2c170e07812b3b2cc0154c4342

commit 0d37fb92c058ad2c170e07812b3b2cc0154c4342
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Dec 11 12:46:42 2018

Add API to convert AccountTrackerService::FindAccountInfoByXXX

Add methods to find AccountInfo using either account id, email
address or gaia id to IdentityManager. They are wrapper around
the corresponding method of AccountTrackerService (with a call
to GetAccountInfoForAccountWithValidRefreshToken to get the
logic to deal with kSupervisedUserPseudoEmail).

Add unit tests for the new methods.

Bug: 912170
Change-Id: Ic7da17b0f22c85349b89cb44d272a3a6b4f6d573
Reviewed-on: https://chromium-review.googlesource.com/c/1365245
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615502}
[modify] https://crrev.com/0d37fb92c058ad2c170e07812b3b2cc0154c4342/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/0d37fb92c058ad2c170e07812b3b2cc0154c4342/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/0d37fb92c058ad2c170e07812b3b2cc0154c4342/services/identity/public/cpp/identity_manager_unittest.cc

Comment 2 by blundell@chromium.org, Dec 13

Labels: -Pri-1 Pri-2
Moving to P2 to reflect that current milestone is for completing conversion of PO2TS/SigninManager.

Comment 3 by dxie@google.com, Jan 16

Blockedon: 922740

Comment 4 by dxie@google.com, Jan 16

Blockedon: 922741

Comment 5 by dxie@google.com, Jan 16

Blockedon: 922742

Comment 6 by dxie@google.com, Jan 16

Blockedon: 922744

Comment 7 by dxie@google.com, Jan 16

Blockedon: 922745

Comment 8 by dxie@google.com, Jan 16

Blockedon: 922747

Comment 9 by dxie@google.com, Jan 16

Blockedon: 922748

Comment 10 by dxie@google.com, Jan 17

Blockedon: 922785

Comment 11 by dxie@google.com, Jan 17

Blockedon: 922787

Comment 12 by dxie@google.com, Jan 17

Blockedon: 922795

Comment 13 by dxie@google.com, Jan 17

Blockedon: 922796

Sign in to add a comment