New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 912165 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Python exception in telemetry_perf_unittests: "LookupError: unknown encoding: string-escape"

Project Member Reported by erikc...@chromium.org, Dec 5

Issue description

Build: https://chromium-swarm.appspot.com/task?id=4197dba6e0fca410&refresh=10&show_raw=1

"""  
  Traceback (most recent call last):
    _RunStoryAndProcessErrorIfNeeded at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:169
      None
    DidRunStory at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py:296
      None
    StopTracing at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/core/tracing_controller.py:53
      None
    StopTracing at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:157
      None
  TracingException: Exceptions raised when trying to stop tracing:
  Traceback (most recent call last):
    File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py", line 135, in StopTracing
    File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py", line 202, in StopAgentTracing
    File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py", line 297, in _RemoveTraceConfigFile
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 57, in timeout_retry_wrapper
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 158, in Run
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 198, in JoinAll
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 170, in _JoinAll
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 93, in run
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 151, in <lambda>
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1871, in RemovePath
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1860, in _RenamePath
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 51, in timeout_retry_wrapper
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1161, in RunShellCommand
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1130, in handle_large_output
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1112, in handle_large_command
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1103, in handle_check_return
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1099, in run
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/sdk/adb_wrapper.py", line 533, in Shell
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/sdk/adb_wrapper.py", line 316, in _RunDeviceAdbCmd
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 51, in timeout_retry_wrapper
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/sdk/adb_wrapper.py", line 277, in _RunAdbCmd
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/cmd_helper.py", line 413, in GetCmdStatusAndOutputWithTimeout
    File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/cmd_helper.py", line 103, in Popen
    File "/b/swarming/w/ir/.swarming_module/lib/python2.7/subprocess.py", line 390, in __init__
    File "/b/swarming/w/ir/.swarming_module/lib/python2.7/subprocess.py", line 1024, in _execute_child
    File "/b/swarming/w/ir/.swarming_module/lib/python2.7/pickle.py", line 1388, in loads
    File "/b/swarming/w/ir/.swarming_module/lib/python2.7/pickle.py", line 864, in load
    File "/b/swarming/w/ir/.swarming_module/lib/python2.7/pickle.py", line 977, in load_string
  LookupError: unknown encoding: string-escape
"""
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a8f4725aa0039254feba6041d86b03005979c161

commit a8f4725aa0039254feba6041d86b03005979c161
Author: John Budorick <jbudorick@chromium.org>
Date: Wed Dec 05 21:54:36 2018

devil: cache the string-escape codec path at cmd_helper load time.

Bug:  chromium:912165 
Change-Id: I1d4b1124e3835f90def594a5945e7e00ca1920aa
Reviewed-on: https://chromium-review.googlesource.com/c/1363560
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/a8f4725aa0039254feba6041d86b03005979c161/devil/devil/utils/cmd_helper.py

Owner: jbudorick@chromium.org
Status: Started (was: Untriaged)
Explained the reasoning for #1 in https://bugs.chromium.org/p/chromium/issues/detail?id=912292#c2
Cc: bpastene@chromium.org sergeybe...@chromium.org
 Issue 851501  has been merged into this issue.
Issue 820515 has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df92cb505f9cea4413799a66a9e76fb38311424e

commit df92cb505f9cea4413799a66a9e76fb38311424e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Dec 06 01:16:00 2018

Roll src/third_party/catapult fa0beb5bf0c0..a8f4725aa003 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/fa0beb5bf0c0..a8f4725aa003


git log fa0beb5bf0c0..a8f4725aa003 --date=short --no-merges --format='%ad %ae %s'
2018-12-05 jbudorick@chromium.org devil: cache the string-escape codec path at cmd_helper load time.


Created with:
  gclient setdep -r src/third_party/catapult@a8f4725aa003

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:912165 
TBR=sullivan@chromium.org

Change-Id: I0c7b07609a9a2b5d98b0a78700775a9e80fbd9aa
Reviewed-on: https://chromium-review.googlesource.com/c/1364171
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614216}
[modify] https://crrev.com/df92cb505f9cea4413799a66a9e76fb38311424e/DEPS

Comment 6 by jbudorick@chromium.org, Today (10 hours ago)

Status: Fixed (was: Started)
We haven't seen reports of this in over a month. Tentatively marking as fixed.

If this recurs, feel free to reopen this issue (or  issue 912292 , if it occurs in gclient).

Sign in to add a comment