Inconsistent animation when navigation between NTP and a web page in slim nav |
||
Issue descriptionChrome Version (from "Settings > About Google Chrome"): 73.0.3629.0 Device: iPhone 8 Make sure #slim-navigation-manager is enabled in chrome://flags. The navigation animation between NTP and a web page is very inconsistent. There are three issues: 1) A grey box is visible where the omnibox is normally after NTP disappears but before the web content is loaded. 2) When web page starts loading, omnibox is visible with the web URL, but content area is dark grey. See 00:12 in the video. 3) When navigating back from web page to NTP a second time, a black screen is visible (instead of white in the first back navigation, e.g. 00:08 in video). See 00:16 in the video. (3) only affects navigation by edge swipe. (1) and (2) affect both edge swipe and back/forward button taps. They are visible for a much shorter duration when back/forward buttons are used.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a399fc489488bfb1015aa67195def1d81652dd5d commit a399fc489488bfb1015aa67195def1d81652dd5d Author: Justin Cohen <justincohen@google.com> Date: Mon Dec 10 16:25:19 2018 [ios] Fix side swipe navigation card size for NTP. When the toolbar is hidden on the NTP extend the height of the side swipe view. Bug: 912151 Change-Id: Ic6560c522f954f8e544fc8a3fe75efcb310a41ee Reviewed-on: https://chromium-review.googlesource.com/c/1368691 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615140} [modify] https://crrev.com/a399fc489488bfb1015aa67195def1d81652dd5d/ios/chrome/browser/ui/browser_view_controller.mm
,
Dec 10
danyao@ can you verify that (1) and (2) are fixed in tomorrow's canary? I don't think (3) can be fixed, as it's WKWebView drawing the black. I do think we can do better at triggering native edge-swipe in this case, but it's probably best in a separate bug.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28ea91210414c292fe00817ab03b01535a7c25da commit 28ea91210414c292fe00817ab03b01535a7c25da Author: Justin Cohen <justincohen@google.com> Date: Mon Dec 10 16:30:26 2018 [ios] Clean up toolbar hiding logic when transitioning from the NTP. There are times when the NTP can be hidden but before the visibleURL changes. This can leave the BVC in a blank state where only the bottom toolbar is visible. Instead, if possible, use the NewTabPageTabHelper IsActive() value rather than checking -IsVisibleURLNewTabPage. Bug: 912151 Change-Id: I3bb9254ed6ecbb9184a9a75dfb14800444fc42b7 Reviewed-on: https://chromium-review.googlesource.com/c/1368693 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615142} [modify] https://crrev.com/28ea91210414c292fe00817ab03b01535a7c25da/ios/chrome/browser/ui/browser_view_controller.mm
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8bce21c3d446b81949d420cbbce895dacf61c9a commit f8bce21c3d446b81949d420cbbce895dacf61c9a Author: Justin Cohen <justincohen@google.com> Date: Mon Dec 10 17:47:46 2018 [ios] Remove WKWebView default background color. Bug: 912151 Change-Id: Ibb7993986a94bd139443d555f48e2c95800074d5 Reviewed-on: https://chromium-review.googlesource.com/c/1368695 Reviewed-by: Danyao Wang <danyao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615165} [modify] https://crrev.com/f8bce21c3d446b81949d420cbbce895dacf61c9a/ios/web/web_state/ui/crw_web_controller.mm
,
Dec 11
Tested in Build: 73.0.3637.0 Canary Device: iPhone 7plus(iOS 12.1) and iPhone X(iOS 11.4.1) with slim flag enabled issue (1) and (2) looks resolved i.e. on navigating from NTP to web page (1) the grey box is not displayed and (2) the content area is no more dark grey when omnibox with URL is displayed issue (3) is reproducible as per comment#3 this issue will be addressed in a separate bug. Link to video: https://drive.google.com/file/d/1sG0A2zw9tkUHkDe5ZEHQdS9RxhkNOglS/view?usp=sharing
,
Dec 11
|
||
►
Sign in to add a comment |
||
Comment 1 by justincohen@chromium.org
, Dec 7