New issue
Advanced search Search tips

Issue 912150 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 907901
issue 922019

Blocking:
issue 883318



Sign in to add a comment

Port SupervisedUserService to use AccountsMutator rather than ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Dec 5

Issue description

We'll need to first add the API that's equivalent to UpdateCredentials().
 
Blockedon: 907901
The API used by this is:
  * PO2TS::UpdateCredentials()
  * PO2TS::LoadCredentials()

The first one can be replaced with AccountsMutator::AddOrUpdateAccount(), but there are at the moment no mappings for LoadCredentials().

I remember, though, that you initially added AccountsMutator::LoadFromDisk() in crrev.com/c/1333775, which then got removed in crrev.com/c/1374985, but I can't find any comment explaining why it got removed neither on that second CL nor on crbug.com/740117.

Reading a comment in the first CL, I see this comment right before landing:

> > > chrome/browser/supervised_user/supervised_user_service.cc
> > The supervised users are pretty much dead on desktop and theoretically soon to be dead on ChromeOS too (though this discussion has been on-going for more than a year).  Again this is a case where the SigninManager is not used I think.
> > 
> Thanks for the analysis! I agree with all of it. I think that eventually we should not have this method, but at this time we need it. I added a comment saying that it should not be called in normal flow. WDYT?

...where you all seem to acknowledge this API would be needed for now, even if the "supervised user is pretty much dead on desktop".

What is the current status? If this API is not needed anymore, could you clarify how a class like this one is meant to be migrated away from PO2TS?

Thanks in advance!
Blockedon: 922019
Hi Mario,

Thank you for flagging this! I got a little overeager on crrev.com/c/1374985 and simply forgot that LoadCredentials() still had some production usage even with what that CL was removing. I'm following up on  crbug.com/922019  now.

Comment 5 by ma...@igalia.com, Jan 16 (6 days ago)

Nice! Thanks for following up on this one, I was starting to think I was missing something obvious here :-).

Comment 6 by ma...@igalia.com, Jan 16 (6 days ago)

Owner: ma...@igalia.com
Status: Started (was: Available)

Comment 7 by ma...@igalia.com, Jan 16 (6 days ago)

CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1415410
(pending on a legacy API for LoadCredentials() to be available)

Sign in to add a comment