New issue
Advanced search Search tips

Issue 912145 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318
issue 920965



Sign in to add a comment

Convert FamilyInfoFetcher to use IdentityManager instead of ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Dec 5

Issue description

It interacts with an OAuth2TokenService object, which in practice is always ProfileOAuth2TokenService (the only creation site is in ChildAccountService). This usage, and the associated unittest usage, should be ported to IdentityManager.
 
Status: Started (was: Available)
I'm taking this
Owner: svil...@igalia.com
Blocking: 920965
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d3e7edfbf68c9f69f720c49a40a6b51c2656383

commit 9d3e7edfbf68c9f69f720c49a40a6b51c2656383
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Jan 15 11:06:16 2019

Convert FamilyInfoFetcher to use IdentityManager

It was using ProfileOAuth2TokenService to request and track refresh
tokens for family accounts. That could be done with the
IdentityManager API.

A new API was added to IdentityTestEnvironment to reload the
credentials from persistent storage. That was needed by one of the
unit tests.

Bug:  912145 
Change-Id: I0502840c4f14e108da720be6a1bce93a20f34278
Reviewed-on: https://chromium-review.googlesource.com/c/1394523
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#622810}
[modify] https://crrev.com/9d3e7edfbf68c9f69f720c49a40a6b51c2656383/chrome/browser/supervised_user/child_accounts/child_account_service.cc
[modify] https://crrev.com/9d3e7edfbf68c9f69f720c49a40a6b51c2656383/chrome/browser/supervised_user/child_accounts/family_info_fetcher.cc
[modify] https://crrev.com/9d3e7edfbf68c9f69f720c49a40a6b51c2656383/chrome/browser/supervised_user/child_accounts/family_info_fetcher.h
[modify] https://crrev.com/9d3e7edfbf68c9f69f720c49a40a6b51c2656383/chrome/browser/supervised_user/child_accounts/family_info_fetcher_unittest.cc
[modify] https://crrev.com/9d3e7edfbf68c9f69f720c49a40a6b51c2656383/services/identity/public/cpp/identity_test_environment.cc
[modify] https://crrev.com/9d3e7edfbf68c9f69f720c49a40a6b51c2656383/services/identity/public/cpp/identity_test_environment.h

Status: Fixed (was: Started)

Sign in to add a comment