New issue
Advanced search Search tips

Issue 912143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Simplify ManagePasswordsUIProvider code

Project Member Reported by ioanap@chromium.org, Dec 5

Issue description

Currently, most of the logic lives downstream. Upstreaming as much of the logic as possible makes future changes to the code easier and facilitates metrics recording.
 
Description: Show this description
Labels: -M-72 M-73
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2c5a8455d2e376fbe3c8ea58be2eae420d36e4e

commit e2c5a8455d2e376fbe3c8ea58be2eae420d36e4e
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Jan 08 09:50:31 2019

Simplify ManagePasswordsUIProvider code [1/5]

This introduces a new interface, GooglePasswordManagerUIProvider,
aiming to replace the current ManagePasswordsUIProvider code, but
with a narrower scope.

Bug:  912143 
Change-Id: Ia11d8a20195d0bddc6806866096b523681ccc22a
Reviewed-on: https://chromium-review.googlesource.com/c/1367646
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620667}
[modify] https://crrev.com/e2c5a8455d2e376fbe3c8ea58be2eae420d36e4e/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[add] https://crrev.com/e2c5a8455d2e376fbe3c8ea58be2eae420d36e4e/chrome/android/java/src/org/chromium/chrome/browser/password_manager/GooglePasswordManagerUIProvider.java
[modify] https://crrev.com/e2c5a8455d2e376fbe3c8ea58be2eae420d36e4e/chrome/android/java_sources.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/cd3a2597ff924243a177ba826f52ec94f57f9214

commit cd3a2597ff924243a177ba826f52ec94f57f9214
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Jan 08 11:38:01 2019

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/708c4281e9529acd99534ee574f5c72b2ec49098

commit 708c4281e9529acd99534ee574f5c72b2ec49098
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Jan 08 14:29:01 2019

Simplify ManagePasswordsUIProvider code [3/5]

This CL fully replaces ManangePasswordsUIProvider with
GooglePasswordManagerUIProvider, moving most of the checks
needed to decide which UI surface to show to PreferencesLauncher.

Bug:  912143 
Change-Id: I1383730ff4f546577e71ea80ab22357e0e622c5b
Reviewed-on: https://chromium-review.googlesource.com/c/1375727
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620710}
[modify] https://crrev.com/708c4281e9529acd99534ee574f5c72b2ec49098/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
[modify] https://crrev.com/708c4281e9529acd99534ee574f5c72b2ec49098/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/6f0265e7da50949805640d3c570180ad56fb2bae

commit 6f0265e7da50949805640d3c570180ad56fb2bae
Author: Ioana Pandele <ioanap@chromium.org>
Date: Tue Jan 08 16:51:45 2019

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e714f11f1f87ac01609e8c297c41a964e8efbc1

commit 2e714f11f1f87ac01609e8c297c41a964e8efbc1
Author: Ioana Pandele <ioanap@chromium.org>
Date: Wed Jan 09 10:39:20 2019

Simplify ManagePasswordsUIProvider code [5/5]

This change completely removes MangePasswordsUIProvider, which has now
been completely replaced by GooglePasswordManagerUIProvider.

Bug:  912143 
Change-Id: I3d8718d560f579ba179015ff54b2c6abc3807357
Reviewed-on: https://chromium-review.googlesource.com/c/1375929
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621107}
[modify] https://crrev.com/2e714f11f1f87ac01609e8c297c41a964e8efbc1/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[delete] https://crrev.com/07dcd2faf1b173f333f405d5cc34a2a9be8bf59f/chrome/android/java/src/org/chromium/chrome/browser/password_manager/ManagePasswordsUIProvider.java
[modify] https://crrev.com/2e714f11f1f87ac01609e8c297c41a964e8efbc1/chrome/android/java_sources.gni

Status: Fixed (was: Started)

Sign in to add a comment