Test are considered as failed if GTEST_SKIP() is used |
|
Issue descriptiongtest provides a macro GTEST_SKIP() to disable a test at runtime (it can be used if it is not possible to determine at compilation time whether the test can be run or not). Using the macro is nicer than just returning from the tests as it is marked as skipped when reporting the test statuses, like this: [----------] 7 tests from PrimaryAccountMutatorTest [ RUN ] PrimaryAccountMutatorTest.SetSettingPrimaryAccountAllowed [ SKIPPED ] PrimaryAccountMutatorTest.SetSettingPrimaryAccountAllowed (6 ms) [ RUN ] PrimaryAccountMutatorTest.SetPrimaryAccount However, the bots do not like when tests are skipped like this and they report the whole test run to be a failure. Before doing that they report the following: Failed to get out-of-band test success data, dumping full stdio below: Note: Google Test filter = PrimaryAccountMutatorTest.AuthInProgress_SigninCancelled:... I think the code that parse the test output should properly deal with those skipped tests. Note that the tests are considered as success if run locally when some tests are skipped with GTEST_SKIP().
,
Dec 5
Example of CL that tried to use the feature: https://chromium-review.googlesource.com/c/chromium/src/+/1363199/1 Failure log: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/154854 |
|
►
Sign in to add a comment |
|
Comment 1 by sdefresne@chromium.org
, Dec 5