New issue
Advanced search Search tips

Issue 912137 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318
issue 905340
issue 913876



Sign in to add a comment

Determine design for porting ProfileOAuth2TokenService's various delegates to IdentityManager

Project Member Reported by blundell@chromium.org, Dec 5

Issue description

These delegates seem like they likely conceptually belong in the IdentityManager internals. However, we'll need to analyze what extra dependencies they bring in.

This includes the mutable, Android, iOS, and ChromeOS delegates.
 
Blocking: 913876
Blocking: 905340
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce75138065ff1d09c046ec19cc110b919a0ce7fe

commit ce75138065ff1d09c046ec19cc110b919a0ce7fe
Author: Colin Blundell <blundell@chromium.org>
Date: Mon Dec 17 14:17:14 2018

Remove unused O2TSDelegateAndroid includes

Removing these includes helps clarify what dependencies this class has.

Bug: 912137
Change-Id: Id8fd7f2e9ce0f5447b993734a9485bd61a4403ad
Reviewed-on: https://chromium-review.googlesource.com/c/1377424
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617112}
[modify] https://crrev.com/ce75138065ff1d09c046ec19cc110b919a0ce7fe/chrome/browser/signin/oauth2_token_service_delegate_android.cc

Owner: blundell@chromium.org
Status: Started (was: Available)
Cc: msarda@chromium.org
+msarda@ to give feedback on the below:

After thinking about this for a little bit, it definitely seems to me that these belong inside IdentityManager: they form the core of the implementation of ProfileOAuth2TokenService.

Mihai, do you agree?

The first step would be to componentize them so that they live at the same layer as the rest of the code backing IdentityManager. From a quick glance, this seems pretty straightforward:

- the iOS delegate is already inside the component.
- The Android delegate was moved into the component between the time that I filed this bug and now.
- MutablePO2TSDelegate has only very thin //content dependencies.
- The ChromeOS delegate being developed has what looks like thin //chrome dependencies. It depends on //chromeos' AccountManager, but that is expected as that forms the backing store in the new account management system for ChromeOS.
I confirmed with Mihai offline that he's in agreement with c#5. Next step here is to file bugs for componentizing the delegates that are outside the component.

Sign in to add a comment