In Landscape mode, status bar is displayed on opening some of the settings screen |
||||||||||||
Issue descriptionApp Version: 73.0.3631.0 Canary iOS Version: 11.4.1, 12.1.1 beta#3 Device: iPhone and iPad Steps to reproduce: 1. Launch chrome 2. Change the device orientation to landscape 3. Load any webpage (not compulsory issue can be reproducible in NTP) 4. Go to Settings and tap on any option like Search Engine, Payment methods, etc.. 5. Tap on back arrow to go back to settings screen (Step is required to reproduce the issue in tablet) Observed results: At Step 4: Notice that status bar is displayed in iPhone At Step 5: Notice that status bar is displayed in iPad Expected results: Status bar shouldn’t be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Chrome Desktop: NA Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): Yes on M70 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M71 Beta Link to Video: Phone behavior: https://drive.google.com/file/d/1P9-4SGiHX_XQ0gXVio3oBfFH7zWEPFak/view?usp=sharing Tablet behavior: https://drive.google.com/file/d/1WGM8Qv7YiMO2PTiRXdi0d5OlZOMqpuKw/view?usp=sharing
,
Dec 6
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8d77d35a6cd3c9f4e65ec205c8fe45da4a3dafc commit b8d77d35a6cd3c9f4e65ec205c8fe45da4a3dafc Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Dec 07 08:46:00 2018 [iOS] Have default behavior for StatusBar in TableView This CL removes the specific behavior for showing/hiding the Status Bar in the ChromeTableView based on the MDCAppBar (when enabled). It uses the default behavior instead. Bug: 912047 Change-Id: I62d983482d8c3431ac772c6e88ba04c32ccee584 Reviewed-on: https://chromium-review.googlesource.com/c/1365445 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#614644} [modify] https://crrev.com/b8d77d35a6cd3c9f4e65ec205c8fe45da4a3dafc/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
,
Dec 7
,
Dec 8
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f204f80abe472aaced7474cbce8ef73a70b39e84 commit f204f80abe472aaced7474cbce8ef73a70b39e84 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 10 09:20:22 2018 [iOS] Have default behavior for StatusBar in TableView This CL removes the specific behavior for showing/hiding the Status Bar in the ChromeTableView based on the MDCAppBar (when enabled). It uses the default behavior instead. Bug: 912047 Change-Id: I62d983482d8c3431ac772c6e88ba04c32ccee584 Reviewed-on: https://chromium-review.googlesource.com/c/1365445 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614644}(cherry picked from commit b8d77d35a6cd3c9f4e65ec205c8fe45da4a3dafc) Reviewed-on: https://chromium-review.googlesource.com/c/1369786 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#177} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/f204f80abe472aaced7474cbce8ef73a70b39e84/ios/chrome/browser/ui/table_view/chrome_table_view_controller.mm
,
Dec 11
Tested on 73.0.3637.0 Canary, iPad Pro iOS12.1.1, iPhoneXR iOS12.1.1 Issue still repro on iPad in Payment methods Only https://drive.google.com/file/d/1J8TnJ8Gmx8e-0xa0Vzi2WF-Msk-3d3Hq/view
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47a839d1b414f6ccbd7fba08d63bcba6405cb96b commit 47a839d1b414f6ccbd7fba08d63bcba6405cb96b Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 17 11:31:30 2018 [iOS] Use default status bar hidding conditions This CL removes the childViewControllerForStatusBarHidden which was used by the settings to have a non-default behavior for choosing when to show/hide the status bar. This CL makes sure that the default conditions are used. Bug: 912047 Change-Id: I05c7011e429c341d789ea675c7263ba0f2169cda Reviewed-on: https://chromium-review.googlesource.com/c/1378096 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#617085} [modify] https://crrev.com/47a839d1b414f6ccbd7fba08d63bcba6405cb96b/ios/chrome/browser/ui/settings/settings_root_collection_view_controller.mm
,
Dec 17
Asking to merge the new CL.
,
Dec 17
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
Canary verification please.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f204f80abe472aaced7474cbce8ef73a70b39e84 Commit: f204f80abe472aaced7474cbce8ef73a70b39e84 Author: gambard@chromium.org Commiter: gambard@chromium.org Date: 2018-12-10 09:20:22 +0000 UTC [iOS] Have default behavior for StatusBar in TableView This CL removes the specific behavior for showing/hiding the Status Bar in the ChromeTableView based on the MDCAppBar (when enabled). It uses the default behavior instead. Bug: 912047 Change-Id: I62d983482d8c3431ac772c6e88ba04c32ccee584 Reviewed-on: https://chromium-review.googlesource.com/c/1365445 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614644}(cherry picked from commit b8d77d35a6cd3c9f4e65ec205c8fe45da4a3dafc) Reviewed-on: https://chromium-review.googlesource.com/c/1369786 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#177} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 27
This issue has been verified and found fixed in the latest M73 Canary Device: iPhone 7plus, iPad Air OS Version: 12.1, 11.4.1 Build Version: 73.0.3652.0 canary Link to Video: https://drive.google.com/open?id=1yYrqd-c6Whnn6lGuI76lalcqiJkhTH99
,
Jan 3
It seems the latest cl might have been merged before approval. For multiple CL merge requests on a single bug, please be sure to remove all labels pertaining to the previous merge before re-requesting the next merge. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by sczs@chromium.org
, Dec 5Components: -UI>Browser>FullScreen UI>Browser>Mobile>Settings
Labels: M-73
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)