New issue
Advanced search Search tips

Issue 912033 link

Starred by 1 user
Status: Fixed
Owner:
ioanap@chromium.org
Closed: Dec 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Android] Add metrics to log password settings entry points

Project Member Reported by ioanap@chromium.org, Dec 5 
On Android, as on desktop, there are multiple places from which users can navigate to the Passwords page in Settings to view their passwords. We add metrics that record from which place the passwords settings are accessed.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1943e416a4812576cd0adcf53c00c9117839002c

commit 1943e416a4812576cd0adcf53c00c9117839002c
Author: Ioana Pandele <ioanap@chromium.org>
Date: Fri Dec 07 13:22:44 2018

Add metrics for password settings access points on Android

The histograms are currently recorded downstream in CL 725249.

Bug:  912033 
Change-Id: I4266135e3b63ad0bbafdb0a06ea7bd7a2a8c2ee3
Reviewed-on: https://chromium-review.googlesource.com/c/1361722
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614680}
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/android/BUILD.gn
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/android/java/src/org/chromium/chrome/browser/password_manager/ManagePasswordsUIProvider.java
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/browser/android/preferences/preferences_launcher.cc
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/browser/android/preferences/preferences_launcher.h
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/browser/password_manager/password_accessory_controller_impl.cc
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/components/password_manager/core/browser/manage_passwords_referrer.h
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1943e416a4812576cd0adcf53c00c9117839002c/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/2efde5e67303eda23a3e4ad1131d986cf5158210

commit 2efde5e67303eda23a3e4ad1131d986cf5158210
Author: Ioana Pandele <ioanap@chromium.org>
Date: Fri Dec 07 16:12:37 2018

Comment 3 by ioanap@chromium.org, Dec 10

Labels: Merge-Request-72
These metrics are useful for experimenting with the Google Password Manager.
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 11

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/8867c024635ed6ee8b37145bd969b1c65e7dc79e

commit 8867c024635ed6ee8b37145bd969b1c65e7dc79e
Author: Ioana Pandele <ioanap@chromium.org>
Date: Wed Dec 12 10:08:28 2018
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63

commit 6c4e1ca5fa3692b96f7f59ad1257f9de859bae63
Author: Ioana Pandele <ioanap@chromium.org>
Date: Wed Dec 12 10:08:59 2018

[Merge M72]Add metrics for password settings access points on Android

The histograms are currently recorded downstream in CL 725249.

Bug:  912033 
Change-Id: I4266135e3b63ad0bbafdb0a06ea7bd7a2a8c2ee3
Reviewed-on: https://chromium-review.googlesource.com/c/1361722
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614680}(cherry picked from commit 1943e416a4812576cd0adcf53c00c9117839002c)
Reviewed-on: https://chromium-review.googlesource.com/c/1373454
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#278}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/android/BUILD.gn
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/android/java/src/org/chromium/chrome/browser/password_manager/ManagePasswordsUIProvider.java
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/browser/android/preferences/preferences_launcher.cc
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/browser/android/preferences/preferences_launcher.h
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/browser/password_manager/password_accessory_controller_impl.cc
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/components/password_manager/core/browser/manage_passwords_referrer.h
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63/tools/metrics/histograms/histograms.xml

Comment 7 by ioanap@chromium.org, Dec 17

Status: Fixed (was: Started)
Project Member

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/6c4e1ca5fa3692b96f7f59ad1257f9de859bae63

Commit: 6c4e1ca5fa3692b96f7f59ad1257f9de859bae63
Author: ioanap@chromium.org
Commiter: ioanap@chromium.org
Date: 2018-12-12 10:08:59 +0000 UTC

[Merge M72]Add metrics for password settings access points on Android

The histograms are currently recorded downstream in CL 725249.

Bug:  912033 
Change-Id: I4266135e3b63ad0bbafdb0a06ea7bd7a2a8c2ee3
Reviewed-on: https://chromium-review.googlesource.com/c/1361722
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614680}(cherry picked from commit 1943e416a4812576cd0adcf53c00c9117839002c)
Reviewed-on: https://chromium-review.googlesource.com/c/1373454
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#278}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment