Positioning of Seperators in Autofill Manual Fallback |
||||||
Issue descriptionI want to make sure that seperators are positioned vertically centered between two sections. This is already done correctly today between two Addresses, two Credit Cards and two Passwords. However the seperator that divides the Credentials section and the "Manage .." buttons, isn't positioned correctly. See the screen for the correct positioning (left), that uses is already done well (right).
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d604e82d00923e85e22076e806208ab1daa04ba commit 5d604e82d00923e85e22076e806208ab1daa04ba Author: David Jean <djean@google.com> Date: Thu Dec 06 08:34:47 2018 [ios] Fixed manual fallback cells vertical offsets Fixed dynamic types for separating labels. Bug: 912030 , 912028 Change-Id: I1acbfed7fe6569c8af712c45a04b8f86dbbbf0af Reviewed-on: https://chromium-review.googlesource.com/c/1363180 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#614288} [modify] https://crrev.com/5d604e82d00923e85e22076e806208ab1daa04ba/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm [modify] https://crrev.com/5d604e82d00923e85e22076e806208ab1daa04ba/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
,
Dec 6
,
Dec 7
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e69ccf641d1183bbda0210d374cfe74fe5b5d5df commit e69ccf641d1183bbda0210d374cfe74fe5b5d5df Author: David Jean <djean@google.com> Date: Fri Dec 07 10:58:56 2018 [ios] Fixed manual fallback cells vertical offsets Fixed dynamic types for separating labels. Bug: 912030 , 912028 Change-Id: I1acbfed7fe6569c8af712c45a04b8f86dbbbf0af Reviewed-on: https://chromium-review.googlesource.com/c/1363180 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614288}(cherry picked from commit 5d604e82d00923e85e22076e806208ab1daa04ba) Reviewed-on: https://chromium-review.googlesource.com/c/1366328 Cr-Commit-Position: refs/branch-heads/3626@{#133} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/e69ccf641d1183bbda0210d374cfe74fe5b5d5df/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm [modify] https://crrev.com/e69ccf641d1183bbda0210d374cfe74fe5b5d5df/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
,
Dec 11
Autofill separators are displayed correctly. Verified on M73.0.3637.0 canary iOS12.1.2 beta iPhoneX
,
Dec 12
Verified on M72.0.3626.15 beta iOS: 12.1.1, iPad Pro.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e69ccf641d1183bbda0210d374cfe74fe5b5d5df Commit: e69ccf641d1183bbda0210d374cfe74fe5b5d5df Author: djean@google.com Commiter: javierrobles@chromium.org Date: 2018-12-07 10:58:56 +0000 UTC [ios] Fixed manual fallback cells vertical offsets Fixed dynamic types for separating labels. Bug: 912030 , 912028 Change-Id: I1acbfed7fe6569c8af712c45a04b8f86dbbbf0af Reviewed-on: https://chromium-review.googlesource.com/c/1363180 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614288}(cherry picked from commit 5d604e82d00923e85e22076e806208ab1daa04ba) Reviewed-on: https://chromium-review.googlesource.com/c/1366328 Cr-Commit-Position: refs/branch-heads/3626@{#133} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by djean@chromium.org
, Dec 5Owner: djean@chromium.org