New issue
Advanced search Search tips

Issue 912026 link

Starred by 1 user
Status: Assigned
Owner:
hcarmona@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue 921212
issue 919007


Sign in to add a comment

Regression: Focus on back button is not seen for first instance in chrome://extensions page.

Project Member Reported by dipt...@virtusa.com, Dec 5 
Chrome Version: 72.0.3626.7 (Official Build) Revision efcef9a3ecda02b2132af215116a03852d08b9cb-refs/branch-heads/3626@{#63}(32/64 bit)
OS: Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.2) & Linux (14.04 LTS)

Test URL: https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm?hl=en

What steps will reproduce the problem?
(1) Launch chrome, navigate to above url and click on 'ADD TO CHROME' button.
(2) Right click on added extension icon and select 'Options'(it will navigate to chrome://extensions/?options=oemmndcbldboiebfnladdacbdfmadadm)
(3) Now press Esc key, observe then Reload page and observe.
 
Actual: 1. After pressing Esc key focus is not seen on Back button. 
        2. After reloading page focus is seen on Back button.

Expected: 1. Focus should not seen on Back button after reloading button.
          2. Focus should seen on back button for first instance also i.e. after pressing Esc key.

This is a regression issue, broken in 'M68', below is bisect info:

Good Build:68.0.3439.0
Bad Build: 68.0.3440.0

You are probably looking for a change made after 561690 (known good), but no later than 561697 (first known bad).

CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/e44b8a89d4d887f6503ade46df6312526fca4ecc..54af81af521e95e5b51174c87060fa17e3776415

Suspect: https://chromium.googlesource.com/chromium/src/+/8fd1d095826d4a4e021879166bea4149b11561d2

@hcarmona: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.	

Note: Issue is also seen on Stable build #71.0.3578.80, Beta build #71.0.3578.80 and canary build #73.0.3630.0
Actual_Focus.mp4
1.6 MB View Download
Expected_Focus.mp4
521 KB View Download

Comment 1 by hcarmona@chromium.org, Dec 13

Status: Started (was: Assigned)
Focus on the back button is expected.
No focus when the dialog closes is unexpected, I've created a CL to focus the options button when the dialog closes: https://crrev.com/c/1377494

Comment 3 by hcarmona@chromium.org, Jan 4

Status: Fixed (was: Started)
Options button should be focused after closing the options dialog now.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861

commit d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Jan 04 02:55:24 2019

Revert "Extensions: Focus correct button on options dialog close."

This reverts commit 5aa7731c3075fe63d1f016252fc094bba1491d17.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 619843 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWFhNzczMWMzMDc1ZmU2M2QxZjAxNjI1MmZjMDk0YmJhMTQ5MWQxNww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/30552

Sample Failed Step: network_service_browser_tests on Windows-10-15063

Sample Flaky Test: CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog

Original change's description:
> Extensions: Focus correct button on options dialog close.
> 
> Also fix some const references surfaced by presubmit.
> 
> Bug: 912026
> Change-Id: I2661f69f0e63e613a9b8e9d565813c3e27fed340
> Reviewed-on: https://chromium-review.googlesource.com/c/1377494
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#619843}

Change-Id: I66ae0de35342e94b47e76dac658df2eb1f12e4b0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912026,  919007 
Reviewed-on: https://chromium-review.googlesource.com/c/1395717
Cr-Commit-Position: refs/heads/master@{#619870}
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/test/data/extensions/options_page_in_view/manifest.json
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/d4cdafc0e9dfc5b08d7c0d5aa95902d2a87b1861/chrome/test/data/webui/extensions/manager_test.js

Comment 5 by hcarmona@chromium.org, Jan 4

Status: Started (was: Fixed)
Fix was reverted, investigating

Comment 6 by hcarmona@chromium.org, Jan 4

Blockedon: 919007

Comment 8 by hcarmona@chromium.org, Jan 11

Status: Fixed (was: Started)
Should be fixed now that change has landed again. I was able to investigate the test failure and current CL should no longer fail on bots.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237

commit 188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Jan 11 23:22:13 2019

Revert "Extensions: Focus correct button on options dialog close."

This reverts commit 520af7b3824dd819dd134c926024234efd38e301.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 622110 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNTIwYWY3YjM4MjRkZDgxOWRkMTM0YzkyNjAyNDIzNGVmZDM4ZTMwMQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/18532

Sample Failed Step: network_service_browser_tests on Intel GPU on Mac on Mac-10.12.6

Sample Flaky Test: CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog

Original change's description:
> Extensions: Focus correct button on options dialog close.
> 
> Also fix some const references surfaced by presubmit.
> 
> Bug: 912026
> Change-Id: If18dc61d8284c86cbec9f23e09286e9c5f666824
> Reviewed-on: https://chromium-review.googlesource.com/c/1405459
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622110}

Change-Id: I28c92c8792556c3db05081a4aa2df3fe0eb91e91
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 912026, 921212
Reviewed-on: https://chromium-review.googlesource.com/c/1407786
Cr-Commit-Position: refs/heads/master@{#622210}
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/test/data/extensions/options_page_in_view/manifest.json
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/188ece0f9d8bd8fed1bd2fbaebd2b1c151e55237/chrome/test/data/webui/extensions/manager_test.js

Comment 10 by hcarmona@chromium.org, Jan 12

Status: Assigned (was: Fixed)
(╯°□°)╯︵ ┻━┻

Issue was reverted again, different bot failure. Will investigate before re-landing again

Comment 11 by hcarmona@chromium.org, Jan 12

Blockedon: 921212
►

Sign in to add a comment