Regression : Unable to open 'More actions' drop down list in chrome://settings/languages.
Reported by
rp...@virtusa.com,
Dec 5
|
||||||||||
Issue descriptionChrome Version:72.0.3626.7 (Official Build) Revision efcef9a3ecda02b2132af215116a03852d08b9cb-refs/branch-heads/3626@{#63}(32/64-bit) OS: Windows(7,8,8.1,10) , Mac(10.13.1 , 10.13.6 , 10.14.2) and Linux(14.04 LTS)OS What steps will reproduce the problem? 1. Launch chrome ,navigate to chrome://settings/languages 2. From 'Add languages' overlay add 5 languages and try to remove one by one from bottom most language on clicking 'More actions' iron icon. 3. Click on 'More actions' iron icon of second last language item from bottom and observe on clicking Actual : Unable to open 'More actions' drop down list on clicking 'More actions' iron icon Expected: Should be able to open 'More actions' drop down list on clicking 'More actions' iron icon This is a regression issue broken in ‘M-72’ and below is the bisect information: Good Build: 72.0.3583.0 (Revision : 600164) Bad Build : 72.0.3584.0 (Revision : 600616) You are probably looking for a change made after 600224 (known good), but no later than 600225 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/a1f14a1097fa402e72b99c5cab944b2d588bbc79..177774d57a744b75630cba5507c3bf1ed419aea3 Suspecting: https://chromium.googlesource.com/chromium/src/+/177774d57a744b75630cba5507c3bf1ed419aea3 @dpapad: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly review the attached screen-cast for reference. Note : Able to reproduce issue on Canary #73.0.3630.0 Thank you.
,
Dec 5
There seems to be a problem with the languages removal logic, regardless of whether WebUIPolymer2 flag is on or off. The action menu not opening indeed only happens when the flag is on though. Repro steps: 1) Have two languages only. 2) Try to remove the either one. 3) Observe the dev tools console for runtime errors. @aee: Could you take a look on what is causing the error to begin with, and secondarily why the action menu no longer opens if WebUIPolymer2 flag is on? FWIW, I went as far back as r453793 and the problem still occurs there.
,
Dec 5
Issue 908112 has been merged into this issue.
,
Dec 5
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9104602ccfdcdd9a9e416bdc340f309d3186c54 commit f9104602ccfdcdd9a9e416bdc340f309d3186c54 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Dec 06 00:52:07 2018 Settings WebUI: fix issue with removing second to last language Bug: 912022 Change-Id: I510b34f0863a4de639a36d33d73606fce94e7917 Reviewed-on: https://chromium-review.googlesource.com/c/1364051 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#614203} [modify] https://crrev.com/f9104602ccfdcdd9a9e416bdc340f309d3186c54/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/f9104602ccfdcdd9a9e416bdc340f309d3186c54/chrome/test/data/webui/settings/languages_page_tests.js
,
Dec 6
,
Dec 6
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 6
,
Dec 6
Removing merge-tbd as this is requested for 72-merge
,
Dec 7
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b358724c729114aad949eaf2af6a9b127a295b9a commit b358724c729114aad949eaf2af6a9b127a295b9a Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Dec 07 20:18:04 2018 Settings WebUI: fix issue with removing second to last language Bug: 912022 Change-Id: I510b34f0863a4de639a36d33d73606fce94e7917 Reviewed-on: https://chromium-review.googlesource.com/c/1364051 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614203}(cherry picked from commit f9104602ccfdcdd9a9e416bdc340f309d3186c54) Reviewed-on: https://chromium-review.googlesource.com/c/1368451 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#149} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b358724c729114aad949eaf2af6a9b127a295b9a/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/b358724c729114aad949eaf2af6a9b127a295b9a/chrome/test/data/webui/settings/languages_page_tests.js
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b358724c729114aad949eaf2af6a9b127a295b9a Commit: b358724c729114aad949eaf2af6a9b127a295b9a Author: aee@chromium.org Commiter: aee@chromium.org Date: 2018-12-07 20:18:04 +0000 UTC Settings WebUI: fix issue with removing second to last language Bug: 912022 Change-Id: I510b34f0863a4de639a36d33d73606fce94e7917 Reviewed-on: https://chromium-review.googlesource.com/c/1364051 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614203}(cherry picked from commit f9104602ccfdcdd9a9e416bdc340f309d3186c54) Reviewed-on: https://chromium-review.googlesource.com/c/1368451 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#149} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by rbasuvula@google.com
, Dec 5Labels: ReleaseBlock-Stable