New issue
Advanced search Search tips

Issue 911991 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Autofill popup list doesn't scroll on pressing down arrow key.

Project Member Reported by cdin...@virtusa.com, Dec 5

Issue description

Chrome Version: 72.0.3626.7 (Official Build) Revision	efcef9a3ecda02b2132af215116a03852d08b9cb-refs/branch-heads/3626@{#63} (32/64-bit)
OS: Windows (7, 8, 8.1, 10), Mac(10.13.1 , 10.13.6 , 10.14.2) and Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch Chrome, go to www.facebook.com and save 8-10 passwords.
2. Restore down the browser and resize it from bottom to top.
3. Click on 'Email or Phone' text-box to open Autofill popup list (scrollbar will appear on Autofill popup list).
4. Now press down arrow key from keyboard and observe the scrollbar on Autofill popup list.

Actual: Scrollbar doesn't scroll on pressing down arrow key from keyboard.
Expected: Scrollbar should scroll on pressing down arrow key from keyboard.

This is a regression issue, broken in M-61 series, below is manual regression:

Good build: 61.0.3150.0 (Revision: 484425)
Bad build: 61.0.3152.0 (Revision: 485105)

You are probably looking for a change made after 484924 (known good), but no later than 484925 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/4184c40a509a3634d34992c2d93d056cebf7e695..a29d2a463f0a9ea795f380cd1d85f1ba16256077

Suspecting: https://chromium.googlesource.com/chromium/src/+/a29d2a463f0a9ea795f380cd1d85f1ba16256077

@mathp: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: This issue is also reproducible on Stable #71.0.3578.80, Beta #71.0.3578.80, Dev #72.0.3622.0 & Canary #73.0.3630.0

Kindly review the attached screen-cast for reference.

Thank You..!
 
Actual behavior.mp4
1.3 MB View Download
Expected behavior.mp4
848 KB View Download
Cc: tmartino@chromium.org ftirelo@chromium.org
Owner: bsep@chromium.org
+bsep@: could you please take a look at this?

I expected to get that for free from views::ScrollView. Is there any property that we should set to make it work as expected? This is where we are creating the ScrollView object: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc?l=974


Cc: -ftirelo@chromium.org
Owner: ftirelo@chromium.org
I'm not sure you do actually get that for free. You may need to call ScrollToPosition when the selection changes (for example: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/intent_picker_bubble_view.cc?l=419&rcl=3f9dee952f3db4b04949971f7720d8f5d6703b0b). I would try that first.

Otherwise I don't really have time to dig into it. If you need someone from our team to help, send to dfried@ for triage.
The solution proposed in #2 works. I have a CL under review, will address some final comments and land it once I come back from vacations.

Sign in to add a comment