New issue
Advanced search Search tips

Issue 911958 link

Starred by 2 users
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Dec 12
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
rbpotter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : Unwanted movement of 'Custom' radio button is seen when error message appears.

Project Member Reported by sav...@virtusa.com, Dec 5 
Chrome Version : 72.0.3626.7 (Official Build) efcef9a3ecda02b2132af215116a03852d08b9cb-refs/branch-heads/3626@{#63} 32/64 bit
OS : Mac(10.13.6, 10.13.1, 10.14.2), Windows(7,8,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings page and set 'Font size' to 'Small'.
2. Hit 'Cmd + P' to open print preview and type "0" in 'Custom' text field. 
3. Observe the radio button.

Actual Result : Unwanted movement of 'Custom' radio button is seen when error message appears.

Expected Result : 'Custom' radio button should not move from it's position when error message appears below 'Custom' text field.

This is a regression issue broken in M-72 and below is the bisect information:
Good Build : 72.0.3618.0 (Revision : 610279)
Bad Build : 72.0.3619.0 (Revision : 610515)

CHANGE LOG URL:
https://chromium.googlesource.com/chromium/src/+log/33f395ae2a74e955ab820e43c037e86747d36b2e..7ede47e3b1552739bc556b038ebbef082cf5fcce

Suspecting: https://chromium.googlesource.com/chromium/src/+/7ede47e3b1552739bc556b038ebbef082cf5fcce

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Able to reproduce this issue in latest Canary #73.0.3630.0

Thank you..!
Actual_Result.mov
7.3 MB View Download
Expected_Result.mov
6.2 MB View Download

Comment 1 by rbpotter@chromium.org, Dec 5

Labels: -Pri-1 Pri-3
Lowering priority since this only happens with small font sizes.

Comment 2 by rbpotter@chromium.org, Dec 7

Cc: rbpotter@chromium.org
 Issue 912482  has been merged into this issue.

Comment 3 by rbpotter@chromium.org, Dec 11 

Screenshot of fix attached.
Screenshot_bug911958.png
38.0 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4777f8cc64fdf756c1124c79da2ff332eafeb2f

commit c4777f8cc64fdf756c1124c79da2ff332eafeb2f
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Dec 11 04:47:23 2018

Print Preview: Fix polish bug with custom margins radio button

Previously, the height of the custom margins error message was fixed
at 2 lines of text. However, this resulted in the message being cut off
for some languages/font sizes. Allowing a variable height error message
broke the logic setting the custom radio button's position, so this CL
updates the positioning logic so that the radio button stays centered
on the cr-input regardless of the height of the error message.

Bug:  911958 
Change-Id: If9e1655e0d2bb87de46ac3c1749b5b07cd831bd7
Reviewed-on: https://chromium-review.googlesource.com/c/1369027
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615431}
[modify] https://crrev.com/c4777f8cc64fdf756c1124c79da2ff332eafeb2f/chrome/browser/resources/print_preview/new/pages_settings.html

Comment 5 by cdin...@virtusa.com, Dec 12

Labels: TE-Verified-M73 TE-Verified-73.0.3638.0
Update:
Rechecked this issue on Mac(10.13.6, 10.13.1, 10.14.2), Windows(7,8,10) and Linux(14.04 LTS) machines using latest Canary #73.0.3638.0 and issue is fixed. Hence adding TE-Verified labels.

Please refer the attached screen-cast for reference.

Thank you..!
Fixed behavior.mp4
621 KB View Download

Comment 6 by rbpotter@chromium.org, Dec 12

Status: Verified (was: Assigned)
►

Sign in to add a comment