Issue metadata
Sign in to add a comment
|
*/TwoClientWalletSyncTest.DeleteServerAddressMetadataWhenDataGetsRemoved/* is flaky |
||||||||||||||||||||||||
Issue descriptionFindit identified the culprit r613261 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjE2ZWIzOGFkNjAzNTJkYmRmNzI0MWViYjBmNDBiNTQ2ZDExOTdhMQw Please revert the culprit, or disable the test(s) and find the appropriate owner to fix or delete. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r613261&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjE2ZWIzOGFkNjAzNTJkYmRmNzI0MWViYjBmNDBiNTQ2ZDExOTdhMQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Dec 6
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7810b8be795d32099d6589963c0ed8949106bbab commit 7810b8be795d32099d6589963c0ed8949106bbab Author: Jeffrey Yasskin <jyasskin@chromium.org> Date: Fri Dec 07 01:09:58 2018 Revert "[AF] Test that removing wallet data results in removing wallet metadata" This reverts commit f16eb38ad60352dbdf7241ebb0f40b546d1197a1. Reason for revert: FindIt says its tests are flaky: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjE2ZWIzOGFkNjAzNTJkYmRmNzI0MWViYjBmNDBiNTQ2ZDExOTdhMQw Original change's description: > [AF] Test that removing wallet data results in removing wallet metadata > > This CL adds two more sync integration tests for autofill wallet sync. > > Bug: 894001 > Change-Id: I00e1db0e44aba311a0872e88eddf50f395d33fb7 > Reviewed-on: https://chromium-review.googlesource.com/c/1358508 > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613261} TBR=sebsg@chromium.org,jkrcal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894001 , 911953 Change-Id: I20bb26bbd973d8ee7411c3269dc4ab6f98e0e272 Reviewed-on: https://chromium-review.googlesource.com/c/1366876 Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org> Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> Cr-Commit-Position: refs/heads/master@{#614528} [modify] https://crrev.com/7810b8be795d32099d6589963c0ed8949106bbab/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc [modify] https://crrev.com/7810b8be795d32099d6589963c0ed8949106bbab/chrome/browser/sync/test/integration/wallet_helper.cc [modify] https://crrev.com/7810b8be795d32099d6589963c0ed8949106bbab/chrome/browser/sync/test/integration/wallet_helper.h
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6eb1e839b9a61305ced9868a2f865be32ed09e3 commit e6eb1e839b9a61305ced9868a2f865be32ed09e3 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Dec 12 17:24:57 2018 [AF] Fix flakiness in integration tests for server address metadata sync This is a speculative fix of rare flakiness. Before this CL, in rare cases, each client would have a different fake time value. Combined with another rare race condition in converting server addresses to local addresses, it would result in initial sync never converging. Bug: 911953 Change-Id: Ic628cac80b0ffd8977bb29fa5948109366801803 Reviewed-on: https://chromium-review.googlesource.com/c/1373843 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615939} [modify] https://crrev.com/e6eb1e839b9a61305ced9868a2f865be32ed09e3/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5793941dcdbd290493e884e8b10fc4894ea8b97d commit 5793941dcdbd290493e884e8b10fc4894ea8b97d Author: Jan Krcal <jkrcal@chromium.org> Date: Thu Dec 13 07:20:23 2018 [AF] Log more info to debug rare flakiness in sync integration tests CL to be reverted once the investigation is over. Bug: 911953 Change-Id: Ie76891b6cb140b6a1244e17e12f2884310669484 Reviewed-on: https://chromium-review.googlesource.com/c/1373846 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#616234} [modify] https://crrev.com/5793941dcdbd290493e884e8b10fc4894ea8b97d/chrome/browser/sync/test/integration/wallet_helper.cc
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c3e16e388b652f610ce0c05d1f058cbee755dd9 commit 2c3e16e388b652f610ce0c05d1f058cbee755dd9 Author: Jan Krcal <jkrcal@chromium.org> Date: Thu Dec 13 13:40:45 2018 [AF] Debug flaky sync_integration_tests with more debug info CL to be reverted once the investigation is over. Bug: 911953 Change-Id: Iae2e9f4c11ca3a8ecbe04b196c055206aa003b32 Reviewed-on: https://chromium-review.googlesource.com/c/1375731 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#616294} [modify] https://crrev.com/2c3e16e388b652f610ce0c05d1f058cbee755dd9/chrome/browser/sync/test/integration/wallet_helper.cc
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2f136ca88d521fc0bb3f129c7977c74d1d217e2 commit c2f136ca88d521fc0bb3f129c7977c74d1d217e2 Author: Jan Krcal <jkrcal@chromium.org> Date: Mon Dec 17 15:37:29 2018 [AF] Avoid flakiness in address conversion in wallet_metadata tests This CL makes sure we pass the SyncService to PDM before actual sync starts. Passing it later caused a rare flakiness on the waterfall. Bug: 911953 , 911953 Change-Id: I691361de116d1ef8c504cb900f3efe5f3fc8f0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1379893 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#617124} [modify] https://crrev.com/c2f136ca88d521fc0bb3f129c7977c74d1d217e2/chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
,
Jan 7
jkrcal@ should we mark this as fixed?
,
Jan 8
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jyasskin@chromium.org
, Dec 6Owner: jkrcal@chromium.org
Status: Assigned (was: Untriaged)