New issue
Advanced search Search tips

Issue 911952 link

Starred by 1 user
Status: Started
Owner:
tbansal@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add/Remove client hints for redirected requests

Project Member Reported by tbansal@chromium.org, Dec 5 
Currently, we add client hints on navigation requests. At the time of navigation start, we check if the origin has persisted client hints preferences in the past. If so, we add client hints for that origin to the request headers.

However, if the navigation request to a different origin, then we do not recheck if we have persisted client hints for the redirected origin. For redirected naviagations, the browser should add client hints for that origin.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/293a7b6ce7dc7f35dd85a84aac9794f440d70135

commit 293a7b6ce7dc7f35dd85a84aac9794f440d70135
Author: Tarun Bansal <tbansal@chromium.org>
Date: Wed Dec 05 17:41:12 2018

Client hints: Add client hints for the redirected origin

If a navigation request is redirected to an origin
for which the browser has persisted client hints,
then add client hints for that origin.

Change-Id: Ifc9f2dcca9b689846e7e9d3783fee7512e861e98
Bug: 911952
Reviewed-on: https://chromium-review.googlesource.com/c/1362470
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614011}
[modify] https://crrev.com/293a7b6ce7dc7f35dd85a84aac9794f440d70135/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/293a7b6ce7dc7f35dd85a84aac9794f440d70135/chrome/browser/client_hints/client_hints_browsertest.cc

Comment 2 by tbansal@chromium.org, Dec 14

Summary: Add/Remove client hints for redirected requests (was: Add client hints for redirected requests)
We still need to remove client hints for redirected requests.
►

Sign in to add a comment