New issue
Advanced search Search tips

Issue 911949 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

TopControlsSlideControllerTest.TestScrollingPageAndSwitchingToNTP times out on linux-chromeos-rel

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 5

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rakina@google.com

browser_tests failing on chromium.chromiumos/linux-chromeos-rel

Builders failed on: 
- linux-chromeos-rel: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35e7a447e69fda79ee874424d211f17de4628ce9

commit 35e7a447e69fda79ee874424d211f17de4628ce9
Author: Rakina Zata Amni <rakina@chromium.org>
Date: Wed Dec 05 05:36:02 2018

Disable Flaky  TestScrollingPageAndSwitchingToNTP

Failing in linux-chromeos-rel

TBR=pkasting@chromium.org

Bug: 911949
Change-Id: Id15be2a7b0066f530cfe97c721d60dabb5c16aae
Reviewed-on: https://chromium-review.googlesource.com/c/1362596
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613874}
[modify] https://crrev.com/35e7a447e69fda79ee874424d211f17de4628ce9/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc

Cc: afakhry@chromium.org
Labels: -Sheriff-Chromium
Owner: pkasting@chromium.org
Status: Assigned (was: Available)
Disabled flaky test, assigning to owner now.
Cc: -rakina@google.com -afakhry@chromium.org
Components: Tests>Fails UI>Shell>TabletMode
Labels: -Pri-1 -Filed-Via-SoM OS-Chrome Pri-2
Owner: afakhry@chromium.org
Summary: TopControlsSlideControllerTest.TestScrollingPageAndSwitchingToNTP times out on linux-chromeos-rel (was: TopControlsSlideControllerTest.TestScrollingPageAndSwitchingToNTP failing on chromium.chromiumos/linux-chromeos-rel)
Passed 2x on the trybots but failed every run (timeout) on the waterfall until disabled.  Here's a sample stack:

BrowserTestBase received signal: Terminated. Backtrace:
#0 0x5614c9a98c9f base::debug::StackTrace::StackTrace()
#1 0x5614c9f89435 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f888944acb0 <unknown>
#3 0x7f88895126d3 epoll_wait
#4 0x5614ca5005cd epoll_dispatch
#5 0x5614ca4fe0bc event_base_loop
#6 0x5614c9aaabcd base::MessagePumpLibevent::Run()
#7 0x5614c9a3fa25 base::RunLoop::Run()
#8 0x5614c7053d84 (anonymous namespace)::TopControlsSlideControllerTest_TestScrollingPageAndSwitchingToNTP_Test::RunTestOnMainThread()
#9 0x5614c9f8891d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#10 0x5614c9b46fd5 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#11 0x5614c9b45f72 ChromeBrowserMainParts::PreMainMessageLoopRun()
#12 0x5614c73d8532 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#13 0x5614c84060d5 content::BrowserMainLoop::PreMainMessageLoopRun()
#14 0x5614c878cc57 content::StartupTaskRunner::RunAllTasksNow()
#15 0x5614c8404ee0 content::BrowserMainLoop::CreateStartupTasks()
#16 0x5614c84080c8 content::BrowserMainRunnerImpl::Initialize()
#17 0x5614c84032c2 content::BrowserMain()
#18 0x5614c9691bc1 content::ContentMainRunnerImpl::RunServiceManager()
#19 0x5614c9691aa9 content::ContentMainRunnerImpl::Run()
#20 0x5614cb789e56 service_manager::Main()
#21 0x5614c9690124 content::ContentMain()
#22 0x5614c9f88551 content::BrowserTestBase::SetUp()
#23 0x5614c9af8c44 InProcessBrowserTest::SetUp()
#24 0x5614c7857dc0 testing::Test::Run()
#25 0x5614c7858b5f testing::TestInfo::Run()
#26 0x5614c7859087 testing::TestCase::Run()
#27 0x5614c78652c7 testing::internal::UnitTestImpl::RunAllTests()
#28 0x5614c7864e3d testing::UnitTest::Run()
#29 0x5614c9b0e161 base::TestSuite::Run()
#30 0x5614c99fd00d ChromeTestSuiteRunner::RunTestSuite()
#31 0x5614c9fa88cc content::LaunchTests()
#32 0x5614c99fd4c5 LaunchChromeTests()
#33 0x5614c99fcf9e main
#34 0x7f8889435f45 __libc_start_main
#35 0x5614c5ebeeaa _start

This doesn't really mean much.  The (elided) stack means the test is hanging in a TopControlsShownRatioWaiter::WaitForRatio() call, but there are some of those called directly and some from inside ScrollAndExpectTopChromeToBe().

->afakhry who is on the blame line for the whole test.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a92ab3a5b0939fc02b13e6bcce9e5c0b4080e205

commit a92ab3a5b0939fc02b13e6bcce9e5c0b4080e205
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed Jan 16 01:17:11 2019

Update comments on some tests to clarify their associated bugs.

Bug:  396347 , 445155, 911949
TBR: kylixrd
Change-Id: I72d14d9cc3a80be89c039c654204fd0b38fb6dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1413659
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622962}
[modify] https://crrev.com/a92ab3a5b0939fc02b13e6bcce9e5c0b4080e205/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/a92ab3a5b0939fc02b13e6bcce9e5c0b4080e205/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc

Sign in to add a comment