New issue
Advanced search Search tips

Issue 911901 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Worker breakpoints and stepping do not work

Project Member Reported by alph@chromium.org, Dec 5

Issue description

1. Have a worker that receives messages and processes them.
2. Place a breakpoint in the processing function.
3. Make sure new messages arrive while the worker is on pause.
4. Press step over.

The arrived messages are executed prior to the code of function being stepped over.


 
Labels: -Type-Bug ReleaseBlock-Stable Target-72 Type-Bug-Regression
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 10

This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Request-72 OS-Linux OS-Mac OS-Windows
Status: Fixed (was: Assigned)
Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3928c2d5ec8be6e851e3dde7e80734a72d9ed26c

commit 3928c2d5ec8be6e851e3dde7e80734a72d9ed26c
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Dec 10 18:42:18 2018

DevTools: Fix debugger stepping order in workers.

BUG= 911901 
TBR=alph@chromium.org

(cherry picked from commit 80d1f9a53edb2cd5aea5807589c83f4b0b84607e)

Change-Id: I9f8626f43a95d6dd428d9850f72d910fe62583c4
Reviewed-on: https://chromium-review.googlesource.com/c/1363211
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614933}
Reviewed-on: https://chromium-review.googlesource.com/c/1370319
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#217}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/3928c2d5ec8be6e851e3dde7e80734a72d9ed26c/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/3928c2d5ec8be6e851e3dde7e80734a72d9ed26c/third_party/blink/renderer/core/workers/worker_global_scope.h
[add] https://crrev.com/3928c2d5ec8be6e851e3dde7e80734a72d9ed26c/third_party/blink/web_tests/inspector-protocol/debugger/debugger-worker-pause-task-order-expected.txt
[add] https://crrev.com/3928c2d5ec8be6e851e3dde7e80734a72d9ed26c/third_party/blink/web_tests/inspector-protocol/debugger/debugger-worker-pause-task-order.js

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/3928c2d5ec8be6e851e3dde7e80734a72d9ed26c

Commit: 3928c2d5ec8be6e851e3dde7e80734a72d9ed26c
Author: alph@chromium.org
Commiter: alph@chromium.org
Date: 2018-12-10 18:42:18 +0000 UTC

DevTools: Fix debugger stepping order in workers.

BUG= 911901 
TBR=alph@chromium.org

(cherry picked from commit 80d1f9a53edb2cd5aea5807589c83f4b0b84607e)

Change-Id: I9f8626f43a95d6dd428d9850f72d910fe62583c4
Reviewed-on: https://chromium-review.googlesource.com/c/1363211
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614933}
Reviewed-on: https://chromium-review.googlesource.com/c/1370319
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#217}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment