[HTTPS Server Previews] Preview is not triggered after redirect |
||||||
Issue descriptionIf the server sends a 307 to a previewable-page, we don't trigger because this case is not handled in the triggering logic.
,
Dec 5
,
Dec 6
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/179e225bb695f4d4c1df2fb59fdde9e5ec41d142 commit 179e225bb695f4d4c1df2fb59fdde9e5ec41d142 Author: Robert Ogden <robertogden@chromium.org> Date: Thu Dec 06 19:41:57 2018 HTTPS Previews: Run triggering logic after previews server redirect We should be able to retrigger after the previews server sends a 307 to another page (i.e.: doesn't bypass). Bug: 911893 Change-Id: Ib844f65749b5dc71810d4a52baf018b01852f560 Reviewed-on: https://chromium-review.googlesource.com/c/1362483 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614001}(cherry picked from commit ffce7b3ef2f7dc52a2b231d5ed044bc41e540384) Reviewed-on: https://chromium-review.googlesource.com/c/1366265 Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#121} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/179e225bb695f4d4c1df2fb59fdde9e5ec41d142/chrome/browser/previews/previews_lite_page_browsertest.cc [modify] https://crrev.com/179e225bb695f4d4c1df2fb59fdde9e5ec41d142/chrome/browser/previews/previews_lite_page_navigation_throttle.cc
,
Dec 6
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/179e225bb695f4d4c1df2fb59fdde9e5ec41d142 Commit: 179e225bb695f4d4c1df2fb59fdde9e5ec41d142 Author: robertogden@chromium.org Commiter: robertogden@chromium.org Date: 2018-12-06 19:41:57 +0000 UTC HTTPS Previews: Run triggering logic after previews server redirect We should be able to retrigger after the previews server sends a 307 to another page (i.e.: doesn't bypass). Bug: 911893 Change-Id: Ib844f65749b5dc71810d4a52baf018b01852f560 Reviewed-on: https://chromium-review.googlesource.com/c/1362483 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614001}(cherry picked from commit ffce7b3ef2f7dc52a2b231d5ed044bc41e540384) Reviewed-on: https://chromium-review.googlesource.com/c/1366265 Reviewed-by: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#121} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 5