Shelf (with fullscreen window) detaches during drag instead of stretching |
||||||
Issue descriptionChrome Version: 72.0.3623.0 OS: Chrome What steps will reproduce the problem? (1) Switch shelf to side shelf (2) Drag from shelf-side-bezel toward center (3) Observe as the shelf detaches and comes with you What is the expected result? Shelf stretches, but doesn't detach What happens instead? Shelf detaches Bonus Video: https://photos.app.goo.gl/7pcRv3o95W4qc6NPA
,
Dec 10
,
Dec 18
Thanks Kevin! The video is great. I shall note that this happen when there is a full-screen window, or in tablet mode (I don't think it happens in clamshell mode, with a rounded-cornered-shelf).
,
Dec 18
,
Dec 18
,
Dec 18
Arguably, when in this mode (fullscreen, always shown, square cornered shelf), the shelf shouldn't even respond to drags and should stay put.
,
Dec 18
Hmm, actually, I'm not so sure. I kind of like the "overshoot" effect, even in this mode. I'll start by fixing the obvious visual bug and then consult UX on final polish.
,
Dec 18
,
Dec 18
FYI sent out fix as CL 382446
,
Dec 18
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d38df253571d4c4394c3454353ebc0b7442e95a6 commit d38df253571d4c4394c3454353ebc0b7442e95a6 Author: Manu Cornet <manucornet@chromium.org> Date: Tue Dec 18 16:20:31 2018 CrOS shelf: extend background to handle overdrag in any condition Before this CL, we already extend the shelf's opaque background a bit off screen, so that "over-drag" events don't appear to be tearing off the shelf from the screen edge. This CL extends this behavior to "fullscreen" mode (shelf is a little darker, and has square corners) so that there too we prevent a tearing effect. Bug: 911880 Change-Id: I0e91c83824417027060c75ccdd8fdcf1bdb3ffb5 Reviewed-on: https://chromium-review.googlesource.com/c/1382446 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#617514} [modify] https://crrev.com/d38df253571d4c4394c3454353ebc0b7442e95a6/ash/shelf/shelf_widget.cc
,
Dec 18
Probably not serious enough to request a cherry pick into 72. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ginko@google.com
, Dec 5