New issue
Advanced search Search tips

Issue 911877 link

Starred by 1 user
Status: Assigned
Owner:
andreasbutler@google.com
Cc:
pwnall@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

IndexedDB commit() doesn't abort on request errors

Project Member Reported by dmu...@chromium.org, Dec 5 
IDBTransasction.commit() should abort the transaction if there are any request errors. Currently this doesn't happen if the error is hanlded on the request, and probably doesn't happen in the 'shutdown' 'abortalltransactions' optimization.

I'll be uploading a WPT test for the first case.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0bd6d5bc0487315bdc89ba96df55b318cadc7b6

commit b0bd6d5bc0487315bdc89ba96df55b318cadc7b6
Author: Daniel Murphy <dmurph@chromium.org>
Date: Fri Dec 07 01:00:31 2018

[IndexedDB] Testing ordering and error handling for transaction.commit

* Tests that transaction ordering is consistent, even if a transaction
  calls commit().
* Tests that request errors cause a commit()-ed transaction to abort.

The second case seems to be broken in our implementation.

R=andreasbutler@google.com, cmp@chromium.org

Bug: 911877
Change-Id: I47da6ce9d350f6c47afcd02cf808d4fefb5f013f
Reviewed-on: https://chromium-review.googlesource.com/c/1362477
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614512}
[add] https://crrev.com/b0bd6d5bc0487315bdc89ba96df55b318cadc7b6/third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any-expected.txt
[modify] https://crrev.com/b0bd6d5bc0487315bdc89ba96df55b318cadc7b6/third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.js
[add] https://crrev.com/b0bd6d5bc0487315bdc89ba96df55b318cadc7b6/third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.worker-expected.txt
►

Sign in to add a comment