New issue
Advanced search Search tips

Issue 911862 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Zooming in on Mac while Presenting causes strange behaviour

Project Member Reported by braveyao@chromium.org, Dec 4

Issue description

OS: OSX

What steps will reproduce the problem?
(1) Start a screen sharing on Mac
(2) Zooming in/out screen by command+alt+ +/-

What is the expected result?
correct screen content captured


What happens instead?
Odd capture result as in the attachment



 
119645702__18276704__50394.jpeg
2.0 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1d61c430d909d245b32abcd30ee53e93263c9571

commit 1d61c430d909d245b32abcd30ee53e93263c9571
Author: braveyao <braveyao@webrtc.org>
Date: Fri Dec 07 17:22:35 2018

desktopCapture: copy whole screen region when screen is zoomed on OSX

When screen is zoomed in/out, OSX only updates the parts of Rects currently
displayed on screen, with relative location to current top-left on screen.
This will cause problems when we copy the dirty regions to the captured
frame. So we invalidate the whole screen to copy all the screen contents.

- With CGI method, the zooming will be ignored and the whole screen contents
will be captured as before.
- With IOSurface method, the zoomed screen contents will be captured.

Since we can't know the zooming level and focusing location, so we have
to copy the whole screen region for each frame during rooming. And this
will impact peformance a bit (with IOSurface capturer about 5-10 fps
down on MBP.)

Bug:  chromium:911862 
Change-Id: Icf123cde4d686ab7ce28fa731bc8dac6925492c8
Reviewed-on: https://webrtc-review.googlesource.com/c/113101
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Brave Yao <braveyao@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25936}
[modify] https://crrev.com/1d61c430d909d245b32abcd30ee53e93263c9571/modules/desktop_capture/mac/screen_capturer_mac.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa3b8a1a2f60e1c2edb3189f57c12366a5374a28

commit fa3b8a1a2f60e1c2edb3189f57c12366a5374a28
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 10 15:52:06 2018

Roll src/third_party/webrtc 4348ce240aae..b47ccc38e771 (9 commits)

https://webrtc.googlesource.com/src.git/+log/4348ce240aae..b47ccc38e771


git log 4348ce240aae..b47ccc38e771 --date=short --no-merges --format='%ad %ae %s'
2018-12-10 kron@webrtc.org Add chroma siting to ColorSpace
2018-12-10 mirtad@webrtc.org Revert "Replace VideoEncoderFactory::QueryVideoEncoder with VideoEncoder::GetEncoderInfo"
2018-12-10 jonasolsson@webrtc.org Update connection states to match spec changes.
2018-12-07 zstein@webrtc.org Output plots for new DTLS events.
2018-12-07 solenberg@webrtc.org Remove unnecessary includes of common_types.h
2018-12-07 zstein@webrtc.org Reduce transaction ids independent of host byte order.
2018-12-07 benwright@webrtc.org Enable authentication of the header as an optional WebRTC trial.
2018-12-07 terelius@webrtc.org Only create ALR detector in PacedSender if deprecated functions are called.
2018-12-07 braveyao@webrtc.org desktopCapture: copy whole screen region when screen is zoomed on OSX


Created with:
  gclient setdep -r src/third_party/webrtc@b47ccc38e771

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG= chromium:911862 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9a9a8cbd3aceed0478efb254106e72415c12075b
Reviewed-on: https://chromium-review.googlesource.com/c/1369830
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615128}
[modify] https://crrev.com/fa3b8a1a2f60e1c2edb3189f57c12366a5374a28/DEPS

Status: Verified (was: Assigned)
Verified with Canary 73.0.3637.0

Sign in to add a comment