New issue
Advanced search Search tips

Issue 911861 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 889261


Show other hotlists

Hotlists containing this issue:
Chromium-bugs-related-to-Crostini


Sign in to add a comment

Disable FilesApp crostini sharing for M72

Project Member Reported by joelhockey@chromium.org, Dec 4

Issue description

Crostini sharing is being delayed.  See  issue 894299 .
 
Labels: Merge-Request-72
Requesting merge for M72.  This disables crostini sharing features in the FilesApp UI.  The backend features are not yet ready for M72.
Cc: slangley@chromium.org tbuck...@chromium.org
Labels: -Merge-Request-72 Merge-Approved-72
Blocking: 889261
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 5

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de

commit b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Dec 05 23:42:08 2018

FilesApp disable crostini sharing for M72

Bug:  911861 
Bug: 889261
Change-Id: I221f35e7f4c941a7992774de255da575eee29c8a
Reviewed-on: https://chromium-review.googlesource.com/c/1361749
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613833}(cherry picked from commit a3ebc77a883fc4fd522218bab4eb9b14b6cfa02e)
Reviewed-on: https://chromium-review.googlesource.com/c/1362010
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#92}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de/chrome/browser/about_flags.cc
[modify] https://crrev.com/b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de/chromeos/chromeos_features.cc

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83240676bffd24b89e99a17e2ae2cf2fb5d2a957

commit 83240676bffd24b89e99a17e2ae2cf2fb5d2a957
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Dec 05 23:46:51 2018

FilesApp enable crostini sharing for M73

Bug:  911861 
Change-Id: I064324537de34cfe513145e4a9a1f56b6a25a76a
Reviewed-on: https://chromium-review.googlesource.com/c/1361755
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614184}
[modify] https://crrev.com/83240676bffd24b89e99a17e2ae2cf2fb5d2a957/chromeos/chromeos_features.cc

Status: Started (was: Fixed)
I inadvertently removed the flag from chrome:flags, so now users can't override it.  CL coming soon.
Status: Fixed (was: Started)
I'll move this fix to a separate bug.
Labels: CommitLog-Audit-Violation Merge-Without-Approval
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de

Commit: b1fdc97fcc1dab8aafb9c8711fe25ddf5c29c8de
Author: joelhockey@chromium.org
Commiter: joelhockey@chromium.org
Date: 2018-12-05 23:42:08 +0000 UTC

FilesApp disable crostini sharing for M72

Bug:  911861 
Bug: 889261
Change-Id: I221f35e7f4c941a7992774de255da575eee29c8a
Reviewed-on: https://chromium-review.googlesource.com/c/1361749
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613833}(cherry picked from commit a3ebc77a883fc4fd522218bab4eb9b14b6cfa02e)
Reviewed-on: https://chromium-review.googlesource.com/c/1362010
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#92}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment