DCHECK() crash at sign-in |
||||
Issue descriptionRepro: Sign into device. Expected: Signs in normally. Actual: DCHECK() crash. All Chrome OS developers are supposed to be enabling DCHECK()s by default, so this should be fixed ASAP: https://groups.google.com/a/google.com/forum/#!topic/chromeos-ui/IhaLnYGdWVQ #0 0x0000583636d2c57a in logging::LogMessage::~LogMessage() () at ../../base/logging.cc:874 #1 0x0000583634b50d45 in exo::WMHelper::GetInstance() () at ../../components/exo/wm_helper.cc:28 #2 0x0000583639853bb6 in arc::(anonymous namespace)::ArcWindowDelegateImpl::IsInArcAppWindow(aura::Window const*) const () at ../../components/arc/ime/arc_ime_service.cc:57 #3 0x0000583639852257 in arc::ArcImeService::OnWindowFocused(aura::Window*, aura::Window*) () at ../../components/arc/ime/arc_ime_service.cc:245 #4 0x0000583638a80589 in wm::FocusController::SetFocusedWindow(aura::Window*) () at ../../ui/wm/core/focus_controller.cc:259 #5 0x0000583638a7ffcc in wm::FocusController::FocusAndActivateWindow(wm::ActivationChangeObserver::ActivationReason, aura::Window*) () at ../../ui/wm/core/focus_controller.cc:228 #6 0x000058363959604b in ash::Shell::~Shell() () at ../../ash/shell.cc:722 #7 0x0000583639597fde in ash::Shell::~Shell() () at ../../ash/shell.cc:707 #8 0x0000583639a1ba0a in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() () at ../../build/cros_cache/chrome-sdk/tarballs/eve+11244.0.0+target_toolchain/usr/bin/../include/c++/v1/memory:2321 #9 0x0000583636874a8a in ChromeBrowserMainParts::PostMainMessageLoopRun() () at ../../chrome/browser/chrome_browser_main.cc:1891 #10 0x0000583634e22726 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() () at ../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1128 #11 0x0000583633f92ac6 in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() () at ../../content/browser/browser_main_loop.cc:1032 #12 0x0000583633f95300 in content::BrowserMainRunnerImpl::Shutdown() () at ../../content/browser/browser_main_runner_impl.cc:221 #13 0x0000583633f8ee2b in content::BrowserMain(content::MainFunctionParams const&) () at ../../content/browser/browser_main.cc:49 #14 0x00005836368651f0 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) () at ../../content/app/content_main_runner_impl.cc:543 #15 0x0000583636865096 in content::ContentMainRunnerImpl::Run(bool) () at ../../content/app/content_main_runner_impl.cc:866 #16 0x000058363686c945 in service_manager::Main(service_manager::MainParams const&) () at ../../services/service_manager/embedder/main.cc:472 #17 0x0000583636863431 in content::ContentMain(content::ContentMainParams const&) () at ../../content/app/content_main.cc:19 #18 0x0000583632d4c69f in ChromeMain () at ../../chrome/app/chrome_main.cc:102 #19 0x00007dd8589a7a94 in __libc_start_main (main=0x583632d4c600 <main>, argc=31, argv=0x7fff0e836608, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fff0e8365f8) at ../csu/libc-start.c:308 #20 0x0000583632d4c4c9 in _start ()
,
Dec 6
hanada-san, can you look into this?
,
Dec 6
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6dec3971cf136c5f6bfd2fcb197b0da132d12fa commit d6dec3971cf136c5f6bfd2fcb197b0da132d12fa Author: Yuichiro Hanada <yhanada@chromium.org> Date: Thu Dec 06 07:24:53 2018 Fix DCHECK() crash in ArcImeService. It should use WMHelper::HasInstance() to check there is WMHelper instance, but WMHelper::GetInstance() was used instead. Bug: 911857 Change-Id: I46249edd757eff5364863365983be6bef905505c Reviewed-on: https://chromium-review.googlesource.com/c/1365093 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#614285} [modify] https://crrev.com/d6dec3971cf136c5f6bfd2fcb197b0da132d12fa/components/arc/ime/arc_ime_service.cc
,
Dec 6
|
||||
►
Sign in to add a comment |
||||
Comment 1 by penghuang@chromium.org
, Dec 5